Re: [PATCH v1] docs: verify/bisect: fixes, finetuning, and support for Arch

[Bagas Sanjaya <bagasdotme@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 3307 bytes --]

On Thu, Mar 07, 2024 at 09:56:47AM +0100, Linux regression tracking (Thorsten Leemhuis) wrote:
> On 06.03.24 14:27, Bagas Sanjaya wrote:
> > On Wed, Mar 06, 2024 at 10:21:12AM +0100, Thorsten Leemhuis wrote:
> >> diff --git a/Documentation/admin-guide/verify-bugs-and-bisect-regressions.rst b/Documentation/admin-guide/verify-bugs-and-bisect-regressions.rst
> >> index 54bde8bac95c67..58211840ac6ffb 100644
> >> --- a/Documentation/admin-guide/verify-bugs-and-bisect-regressions.rst
> >> +++ b/Documentation/admin-guide/verify-bugs-and-bisect-regressions.rst
> >> @@ -192,8 +192,8 @@ will be considered the 'good' release and used to prepare the .config file.
> >>  
> >>         sudo rm -rf /lib/modules/6.0-rc1-local-gcafec0cacaca0
> >>         sudo kernel-install -v remove 6.0-rc1-local-gcafec0cacaca0
> >> -       # * Note, if kernel-install is missing, you will have to
> >> -       #   manually remove the kernel image and related files.
> >> +       # * Note, on some distributions kernel-install is missing
> >> +       #   or does only part of the job.
> > 
> > Consult documentation of your distribution for how to manually install/remove
> > the kernel.
> 
> That would sent the wrong message in the TLDR, as the step-by-step guide
> and the reference section would be the first place to look for details,
> which is kinda implicit for a TLDR.
> 
> That being said: that made me look closer at the install section of the
> guide and the reference section. I think they should mention "consult
> documentation of your distribution" more clearly. I just looked into
> this, but that requires a few bigger changes, so I'll take care of that
> in a later patch I hope to send in the next few days.
> 
> >>  Install build requirements
> >>  --------------------------
> >> @@ -1076,72 +1078,103 @@ about to build.
> >>  Here are a few examples what you typically need on some mainstream
> >>  distributions:
> >>  
> >> +* Arch Linux and derivatives::
> >> +
> >> +    sudo pacman --needed -S bc binutils bison flex gcc git kmod libelf openssl \
> >> +      pahole perl zlib ncurses qt6-base
> >> +
> >>  * Debian, Ubuntu, and derivatives::
> >>  
> >> -    sudo apt install bc binutils bison dwarves flex gcc git make openssl \
> >> -      pahole perl-base libssl-dev libelf-dev
> >> +    sudo apt install bc binutils bison dwarves flex gcc git kmod libelf-dev \
> >> +      libssl-dev make openssl pahole perl-base pkg-config zlib1g-dev \
> >> +      libncurses-dev qt6-base-dev g++
> >>  
> >>  * Fedora and derivatives::
> >>  
> >> -    sudo dnf install binutils /usr/include/{libelf.h,openssl/pkcs7.h} \
> >> -      /usr/bin/{bc,bison,flex,gcc,git,openssl,make,perl,pahole}
> >> +    sudo dnf install binutils \
> >> +      /usr/bin/{bc,bison,flex,gcc,git,openssl,make,perl,pahole,rpmbuild} \
> >> +      /usr/include/{libelf.h,openssl/pkcs7.h,zlib.h,ncurses.h,qt6/QtGui/QAction}
> > 
> > IMO qt packages are for people who wish to do xconfig instead of menuconfig
> > or nconfig.
> 
> Well, yes, that's why the patch also added a few lines to point this out
> and mention that installing the qt dev headers is optional. Guess you
> just missed that.
> 

OK, thanks!

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]