From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 060152D05E; Mon, 18 Mar 2024 10:25:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710757545; cv=none; b=Fu6W9sFtk1m9UNTjgqHat7XVm6CHOH/RiQobEGAI6Kdivypj+tLJunprEDqV+X0UHDVhOD6U3sVnZ7ojhpcqnj3qowHGmiqxqRwVc1u7i+ACRk5v1LjEC4cmBoZAj6wHCvoT9C6Zj4mKtxgq7KZ9L8bLqUHjRwre/JCRQ/V61AM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710757545; c=relaxed/simple; bh=D3i4B1/kUtjh2CpcNv1sVfMNLfGhvfY5mN0F46ju5IA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fMxlnVcmkVeEnheHgvGYojELVZCnGNMPhfL26sqgNx0qtQxZxbOcaaOimniSHs2wxOx3+bSfwJoKFEe44hoGRcd5qiVW8VSK4skpjqBfYniEg2c+vO6Efgqf+OFhlgAFr5AzcjfQJ05Dp2ai7p5ArI3gxMIvL6yeSPw0uc+x8xo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com; spf=fail smtp.mailfrom=gmail.com; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=gmail.com X-IronPort-AV: E=McAfee;i="6600,9927,11016"; a="17008645" X-IronPort-AV: E=Sophos;i="6.07,134,1708416000"; d="scan'208";a="17008645" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2024 03:25:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11016"; a="914587837" X-IronPort-AV: E=Sophos;i="6.07,134,1708416000"; d="scan'208";a="914587837" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2024 03:25:41 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rmABX-0000000DufE-0yl7; Mon, 18 Mar 2024 12:25:39 +0200 Date: Mon, 18 Mar 2024 12:25:39 +0200 From: Andy Shevchenko To: Peng Fan Cc: "Peng Fan (OSS)" , "linus.walleij@linaro.org" , "brgl@bgdev.pl" , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] gpiolib: use dev_err when gpiod_configure_flags failed Message-ID: References: <20240315011015.3106272-1-peng.fan@oss.nxp.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Mon, Mar 18, 2024 at 02:03:12AM +0000, Peng Fan wrote: > > Subject: Re: [PATCH] gpiolib: use dev_err when gpiod_configure_flags failed > > On Fri, Mar 15, 2024 at 3:02 AM Peng Fan (OSS) > > wrote: ... > > It's unclear what the use case is and how this does make life easier. > > We need to know more! > > I forgot to add gpio-ranges in gpio node, then it always fail in my driver > probe to configure pinctrl. So if using dev_err(), it will be easier for > me to locate the error point. At least make sure something like the above is in the commit message of the next version. -- With Best Regards, Andy Shevchenko