From: Matthew Wilcox <willy@infradead.org>
To: Mike Galbraith <efault@gmx.de>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [patchlet] locking: fix trivial f70405afc99b RT build breakage
Date: Thu, 4 Apr 2024 13:46:12 +0100 [thread overview]
Message-ID: <Zg6hFEQPnP3KIwQ0@casper.infradead.org> (raw)
In-Reply-To: <68731eaeb522ced5319e3c1e45f03cdca5c8fd2a.camel@gmx.de>
On Thu, Apr 04, 2024 at 07:02:41AM +0200, Mike Galbraith wrote:
>
> Two trivial RT build issues arrived along with f70405afc99b: WARN_ON() being
> undefined as added to include/linux/rwbase_rt.h, and the wrong parameter (typo)
> being passed to rw_base_assert_held_write().
>
> Fixes: f70405afc99b ("locking: Add rwsem_assert_held() and rwsem_assert_held_write()")
> Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
> Signed-off-by: Mike Galbraith <efault@gmx.de>
Is Sebastian's patch not merged yet?
https://lore.kernel.org/lkml/20240319182050.U4AzUF3I@linutronix.de/
> include/linux/rwbase_rt.h | 1 +
> include/linux/rwsem.h | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> --- a/include/linux/rwbase_rt.h
> +++ b/include/linux/rwbase_rt.h
> @@ -4,6 +4,7 @@
>
> #include <linux/rtmutex.h>
> #include <linux/atomic.h>
> +#include <linux/bug.h>
>
> #define READER_BIAS (1U << 31)
> #define WRITER_BIAS (1U << 30)
> --- a/include/linux/rwsem.h
> +++ b/include/linux/rwsem.h
> @@ -174,7 +174,7 @@ static inline void rwsem_assert_held_nol
>
> static inline void rwsem_assert_held_write_nolockdep(const struct rw_semaphore *sem)
> {
> - rw_base_assert_held_write(sem);
> + rw_base_assert_held_write(&sem->rwbase);
> }
>
> static __always_inline int rwsem_is_contended(struct rw_semaphore *sem)
>
next prev parent reply other threads:[~2024-04-04 12:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 5:02 Mike Galbraith
2024-04-04 12:46 ` Matthew Wilcox [this message]
2024-04-04 15:45 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zg6hFEQPnP3KIwQ0@casper.infradead.org \
--to=willy@infradead.org \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®