From: Christoph Hellwig <hch@infradead.org>
To: Yihang Li <liyihang9@huawei.com>
Cc: john.g.garry@oracle.com, yanaijie@huawei.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, dlemoal@kernel.org,
chenxiang66@hisilicon.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, linuxarm@huawei.com,
prime.zeng@huawei.com, yangxingui@huawei.com
Subject: Re: [PATCH v3] scsi: libsas: Allocation SMP request is aligned to 16B
Date: Wed, 27 Mar 2024 23:36:45 -0700 [thread overview]
Message-ID: <ZgUP_ZhWPxHQwZvl@infradead.org> (raw)
In-Reply-To: <20240328062657.581460-1-liyihang9@huawei.com>
> + u8 *p = kzalloc(ALIGN(size, 16), GFP_KERNEL);
No, a magic undocumented 16 here max no sense at all. See the
discussion on the previous iteration.
prev parent reply other threads:[~2024-03-28 6:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 6:26 Yihang Li
2024-03-28 6:34 ` Damien Le Moal
2024-03-28 6:36 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgUP_ZhWPxHQwZvl@infradead.org \
--to=hch@infradead.org \
--cc=chenxiang66@hisilicon.com \
--cc=dlemoal@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=john.g.garry@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liyihang9@huawei.com \
--cc=martin.petersen@oracle.com \
--cc=prime.zeng@huawei.com \
--cc=yanaijie@huawei.com \
--cc=yangxingui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®