From: Christoph Hellwig <hch@infradead.org>
To: Jeff Layton <jlayton@kernel.org>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] fuse: allow FUSE drivers to declare themselves free from outside changes
Date: Tue, 2 Apr 2024 07:49:09 -0700 [thread overview]
Message-ID: <Zgwa5apja6gdQNwx@infradead.org> (raw)
In-Reply-To: <20240402-setlease-v2-1-b098a5f9295d@kernel.org>
On Tue, Apr 02, 2024 at 09:10:59AM -0400, Jeff Layton wrote:
> Traditionally, we've allowed people to set leases on FUSE inodes. Some
> FUSE drivers are effectively local filesystems and should be fine with
> kernel-internal lease support. Others are backed by a network server
> that may have multiple clients, or may be backed by something non-file
> like entirely. On those, we don't want to allow leases.
>
> Have the filesytem driver to set a fuse_conn flag to indicate whether
> the inodes are subject to outside changes, not done via kernel APIs. If
> the flag is unset (the default), then setlease attempts will fail with
> -EINVAL, indicating that leases aren't supported on that inode.
So while this polarity is how we should be doing it, doesn't it risk
breaking all the local fuse file systems? I.e. shouldn't the flag be
inverse to maximize backwards compatibility?
prev parent reply other threads:[~2024-04-02 14:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 13:10 Jeff Layton
2024-04-02 13:23 ` Bernd Schubert
2024-04-02 13:27 ` Jeff Layton
2024-04-02 14:02 ` Amir Goldstein
2024-04-02 14:38 ` Miklos Szeredi
2024-04-02 14:51 ` Jeff Layton
2024-04-02 14:54 ` Miklos Szeredi
2024-04-02 14:57 ` Jeff Layton
2024-04-02 14:49 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zgwa5apja6gdQNwx@infradead.org \
--to=hch@infradead.org \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®