From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 51A8B1420B3 for ; Wed, 17 Apr 2024 14:42:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713364977; cv=none; b=ehhNhRuapYgvg4H0SZPMSqjzuZMj45eBrlvX9oT1QwHiyGYiYjkSUa0B6bGA/1MEKdt1tWWIq9ribnCLADl21RHSb3Y+iGVeF1lO+183W8SGj/uKdQpmfxu7cSzQ/i2UbtkMeJyosMzzACZVQ8bxGf8gCITsJG7mq4JdjUgztpE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713364977; c=relaxed/simple; bh=A6iNNVN41D9bZy50eJqHrqELhUAfW+b93QelEVmrH2I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gDrjtzxUn47/jWtiD9VEbYUwegoz97rO1N/89XyGRI9tPQe0zU7SM7Fcz90vFD7nwlFSGzF0eebksbAvitgi42pcyz+IHDjJFlJCvXVD8lbRVixxbzOder3o2WNFCus6Boqse2a8gi/N4xwWxjweFcgbH3X7Lk3YBdLQGp9XVA4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 835932F; Wed, 17 Apr 2024 07:43:22 -0700 (PDT) Received: from e133380.arm.com (e133380.arm.com [10.1.197.52]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5DEB23F738; Wed, 17 Apr 2024 07:42:51 -0700 (PDT) Date: Wed, 17 Apr 2024 15:42:48 +0100 From: Dave Martin To: Reinette Chatre Cc: James Morse , x86@kernel.org, linux-kernel@vger.kernel.org, Fenghua Yu , Thomas Gleixner , Ingo Molnar , Borislav Petkov , H Peter Anvin , Babu Moger , shameerali.kolothum.thodi@huawei.com, D Scott Phillips OS , carl@os.amperecomputing.com, lcherian@marvell.com, bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com, baolin.wang@linux.alibaba.com, Jamie Iles , Xin Hao , peternewman@google.com, dfustini@baylibre.com, amitsinght@marvell.com, David Hildenbrand , Rex Nie Subject: Re: [PATCH v1 30/31] x86/resctrl: Move the filesystem bits to headers visible to fs/resctrl Message-ID: References: <20240321165106.31602-1-james.morse@arm.com> <20240321165106.31602-31-james.morse@arm.com> <8f4a05d5-2040-4cf2-8c05-a190c25d64db@intel.com> <0baf690b-4ed4-4dad-9f50-e5df93d599fd@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Apr 15, 2024 at 11:03:32AM -0700, Reinette Chatre wrote: > Hi Dave, > > On 4/12/2024 9:20 AM, Dave Martin wrote: > > On Thu, Apr 11, 2024 at 10:43:55AM -0700, Reinette Chatre wrote: > >> Hi Dave, > >> > >> On 4/11/2024 7:28 AM, Dave Martin wrote: > >>> On Mon, Apr 08, 2024 at 08:42:00PM -0700, Reinette Chatre wrote: > >>>> Hi James, > >>>> > >>>> On 3/21/2024 9:51 AM, James Morse wrote: > >>>> .. > >>>>> diff --git a/include/linux/resctrl_types.h b/include/linux/resctrl_types.h > >>>>> index 4788bd95dac6..fe0b10b589c0 100644 > >>>>> --- a/include/linux/resctrl_types.h > >>>>> +++ b/include/linux/resctrl_types.h > >>>>> @@ -7,6 +7,36 @@ > >>>>> #ifndef __LINUX_RESCTRL_TYPES_H > >>>>> #define __LINUX_RESCTRL_TYPES_H > >>>>> > >>>>> +#define CQM_LIMBOCHECK_INTERVAL 1000 > >>>>> + > >>>>> +#define MBM_CNTR_WIDTH_BASE 24 > >>>>> +#define MBM_OVERFLOW_INTERVAL 1000 > >>>>> +#define MAX_MBA_BW 100u > >>>>> +#define MBA_IS_LINEAR 0x4 > >>>>> + > >>>>> +/* rdtgroup.flags */ > >>>>> +#define RDT_DELETED 1 > >>>>> + > >>>>> +/* rftype.flags */ > >>>>> +#define RFTYPE_FLAGS_CPUS_LIST 1 > >>>>> + > >>>>> +/* > >>>>> + * Define the file type flags for base and info directories. > >>>>> + */ > >>>>> +#define RFTYPE_INFO BIT(0) > >>>>> +#define RFTYPE_BASE BIT(1) > >>>>> +#define RFTYPE_CTRL BIT(4) > >>>>> +#define RFTYPE_MON BIT(5) > >>>>> +#define RFTYPE_TOP BIT(6) > >>>>> +#define RFTYPE_RES_CACHE BIT(8) > >>>>> +#define RFTYPE_RES_MB BIT(9) > >>>>> +#define RFTYPE_DEBUG BIT(10) > >>>>> +#define RFTYPE_CTRL_INFO (RFTYPE_INFO | RFTYPE_CTRL) > >>>>> +#define RFTYPE_MON_INFO (RFTYPE_INFO | RFTYPE_MON) > >>>>> +#define RFTYPE_TOP_INFO (RFTYPE_INFO | RFTYPE_TOP) > >>>>> +#define RFTYPE_CTRL_BASE (RFTYPE_BASE | RFTYPE_CTRL) > >>>>> +#define RFTYPE_MON_BASE (RFTYPE_BASE | RFTYPE_MON) > >>>>> + > >>>>> /* Reads to Local DRAM Memory */ > >>>>> #define READS_TO_LOCAL_MEM BIT(0) > >>>>> > >>>> > >>>> Not all these new seem to belong in this file. Could you please confirm? > >>>> > >>>> For example: > >>>> Earlier in series it was mentioned that struct rdtgroup is private to the > >>>> fs so having RDT_DELETED is unexpected as it implies access to struct rdtgroup. > >>>> > >>>> CQM_LIMBOCHECK_INTERVAL seems private to the fs code, so too > >>>> RFTYPE_FLAGS_CPUS_LIST. > >>>> > >>>> Reinette > >>>> > >>> > >>> I'll flag this for James to review. > >>> > >>> These have to be moved out of the x86 private headers, but you're right > >>> that some of them seem logically private to the resctrl core. > >>> > >>> I guess some of these could move to fs/resctrl/internal.h? > >> > >> It looks to me that way. > >> > >>> > >>> OTOH, might it be preferable to keep all the flag definitions for a > >>> given member together for ease of maintenance, even if some are for > >>> resctrl internal use only? > >> > >> Indeed, those RFTYPE flags really seem to be fs code but I agree that > >> architectures' use of RFTYPE_RES_CACHE and RFTYPE_RES_MB does make this > >> complicated and having these in a central place is reasonable to me. > >> > >> Reinette > > > > Maybe we could split these into two groups, and clearly comment the ones > > that have no user outside resctrl as internal use only? > > Another option to consider, which I think you hinted about earlier, is > to add an enum that maps to the RFTYPE_RES_CACHE and RFTYPE_RES_MB > flags. Just like, for example, RDTCTRL_GROUP maps to RFTYPE_CTRL. > The new enum can then be used similar to enum rdt_group_type to pick the > appropriate files based on RFTYPE_RES_CACHE or RFTYPE_RES_MB. > > > > > That's not as clean as removing those definitions from a shared header, > > but at least would help document the issue until/unless a better > > solution is found... > > > > Cheers > > ---Dave (Note, I seem to have responded to that suggestion via my reply on patch 3, rather than here: "x86/resctrl: Move ctrlval string parsing policy away from the arch code" https://lore.kernel.org/lkml/Zh6kRMkqVpu0Km4l@e133380.arm.com/ ) Cheers ---Dave