From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E47F0205E10 for ; Tue, 16 Apr 2024 09:14:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713258850; cv=none; b=mpHcBJKYpxQ080IUVuzx83rg/HmwVMmQUwIsU22Q6rO2GvxEdXQyDCp+EmFYRPagAsIL/FZFMwizrVblNqFCc4mafak/qBA29fVkwsPlFxkmri8PbaOwniPz9M1tTL79iYsJenQueX4+zftxGdUKMal4BtDkur88nZxrDr+auD8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713258850; c=relaxed/simple; bh=SLnMlc+/eK00EmnxeOI7j3/d57CnaPFNk93KmLlRKTE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lXB7sUTbxb/aIGmilWsCqbgwb6Zn0rkuasF/LDjor/MkvM4bt0L74fCrrUWesxdIS4YW5oOuxWeuWZSgqw9Cmd8yNhpt0OFrLFBDFWRbEaImw/6REQLCncKGJy8CK4BVIDQ6aFFH9ib23tOJHffsSuAsHAwZSrtmlQkA/KzYFAU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4D6D5339; Tue, 16 Apr 2024 02:14:36 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 37B373F792; Tue, 16 Apr 2024 02:14:07 -0700 (PDT) Date: Tue, 16 Apr 2024 10:14:04 +0100 From: Sudeep Holla To: "Peng Fan (OSS)" Cc: cristian.marussi@arm.com, linux-arm-kernel@lists.infradead.org, Sudeep Holla , linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH] firmware: arm_scmi: power_control: support suspend command Message-ID: References: <20240415101141.1591112-1-peng.fan@oss.nxp.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240415101141.1591112-1-peng.fan@oss.nxp.com> On Mon, Apr 15, 2024 at 06:11:41PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > Support System suspend notification. Using a work struct to call > pm_suspend. There is no way to pass suspend level to pm_suspend, > so use MEM as of now. > While the change itself is simple and no-controversial, I am bit worried about: 1. The choice of S2R(MEM) by default - not sure if different system prefer different things. The userspace can configure whatever default behaviour expected as S2R IIUC, so should be OK. I need to check though. 2. The userspace needs to keep the wakeup source enabled always which I need to check if it is feasible on all the platforms. If wakeups are not configured properly and suspend is triggered, the system can never resume back. We may need to mention above points at-least as part of commit log. I would wait for some feedback from SCMI users. -- Regards, Sudeep