From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEDC41C0DE9 for ; Mon, 8 Apr 2024 06:04:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712556300; cv=none; b=bUxPOp0vSpaexGsfhlKtHH/VbPRUEtSQ8jjEVhNrJl1ApcgZpmCZZlYg3MAxTlL4N4WDI1jUajnXJsHiP+WIk4OoszKId7LtuK11vqqgSNlKDzMsGwO4Rzq7Na5eeb2WZLVEE/sPOPyXW/M9ES0Tx98J4ElKRdDlMo4orIxeLUM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712556300; c=relaxed/simple; bh=fAuNEA1i9zp4LfY4v9NLyPlSXuhbvpQ2lcsUTLbM0Jk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=e6wcL4BdIA8jNpDGiGt1h/PPwO6Kbv8BMovbxMSrRvNI4QvHjnEp4LO/VBxme4noQhxk+nDnfSCJDBatDMdy30GCrl8IgMkY2ZHzEBGc/j8fjm05az9b07gcNAf/Z90tKgwrMc3d2SrxQvQ5RsdMNgqyRiv61Q2wXmgLeyvDdfo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=PqAW1Qct; arc=none smtp.client-ip=209.85.208.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PqAW1Qct" Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-55a179f5fa1so4702386a12.0 for ; Sun, 07 Apr 2024 23:04:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712556297; x=1713161097; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=HgB1JIhvuY/BO7MAAZPSEqht3ry2nTR4m4F5uYSapxc=; b=PqAW1Qcto4V1Dkp6m1q20/CvN4/7aI6RD5I+9r8mpESZ7/snDNP/tvKVIIrhZA0eZc DG9Sbx9WXI7/vLTcz/JY2BWW+6SOSm6whXcVgEZnkTI/HizTjse0+zC++Q3I9JXoS3dQ j+UUfhZWHHQlPHl8la1PJMcBuvlvnlAREzw1hQ1snAb1/ffXeon6mYqe2NZq5aER9HHz 5faZcxA++/nRGKSgNAG97QP9adaKkmAZ2V6EJOf+RslXxizKL2YG12HOup/SHcX+/K1Z IzDZHBLA0wnm1Hf0dHZ3dcGs22b+y3PVKbLa8pzkMjbDU9YU/OcUIi/LNT/iHrl7aBfu 8M5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712556297; x=1713161097; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HgB1JIhvuY/BO7MAAZPSEqht3ry2nTR4m4F5uYSapxc=; b=sChYMBNUBGnM6gSAPrDEozTh5e3AtF2+wCE4WFgEqTabI7hIFUvc471Npc0ryAJ8r4 ysq96XeQ+XkXGB2qQyEwmnIrnWKGq+VGgko8Hun38JGcjQ/88cRZWaTo9v+jNube3CU/ gu7+zBLof3qNzwJiuBaUhhSbjPYK36Gan1j3U9Ts4So8OHMpSloncfuUskJc/AFXGvxW f9G0UkdA1+/HB2NXBNfOJsWH21TddzIlxp5o/9Vofq9Dj65ixMPfNd4uKQ4BgnrZchE7 gfcCBY2p00TFS3rxdRZxas+vmBEJQLxn7jszQo4RANbWJnNZ9F7zh5IOJIYNSKo6rHKq lwEw== X-Forwarded-Encrypted: i=1; AJvYcCVvTekhLloQxt8qiUOw0ReJvq8uQP25YtFzX/29/GeVkEsbdN9TOR4d91nhLP4Ryp9E7OL/sQi4SgYeXyKo5biSlg9qkKB4IIFKjqSj X-Gm-Message-State: AOJu0Yw5u4Y4udpHKYkdbRRCyGrGQuWi2t4+IgW/boVcvs02LvYG+EUn GOd1gYV+C/2/W8sp7MhxQxQGATz+2ZEodvyGZgkS94/Z5UDMTMl9nCpJHKD6qSY= X-Google-Smtp-Source: AGHT+IFDXy3tWRm2lGYd0E3HusgZ33A7ZYQowDKLk1RHjwU5BYJRl0sgFa686Sl3jgUpELE1zMqbzQ== X-Received: by 2002:a50:871c:0:b0:56e:2e9b:1341 with SMTP id i28-20020a50871c000000b0056e2e9b1341mr5971901edb.38.1712556297079; Sun, 07 Apr 2024 23:04:57 -0700 (PDT) Received: from linaro.org ([79.114.172.194]) by smtp.gmail.com with ESMTPSA id di19-20020a056402319300b0056b7ed75a46sm3764632edb.27.2024.04.07.23.04.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Apr 2024 23:04:56 -0700 (PDT) Date: Mon, 8 Apr 2024 09:04:55 +0300 From: Abel Vesa To: Bjorn Andersson , Krzysztof Kozlowski Cc: Stephen Boyd , Matthias Brugger , Konrad Dybcio , Dmitry Baryshkov , Neil Armstrong , AngeloGioacchino Del Regno , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Srini Kandagatla , Johan Hovold , David Collins , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, Krzysztof Kozlowski Subject: Re: [PATCH v9 1/7] dt-bindings: spmi: Add X1E80100 SPMI PMIC ARB schema Message-ID: References: <20240407-spmi-multi-master-support-v9-0-fa151c1391f3@linaro.org> <20240407-spmi-multi-master-support-v9-1-fa151c1391f3@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 24-04-07 19:07:03, Bjorn Andersson wrote: > On Sun, Apr 07, 2024 at 07:23:21PM +0300, Abel Vesa wrote: > > Add dedicated schema for X1E80100 PMIC ARB (v7) as it allows multiple > > buses by declaring them as child nodes. > > > > But is this really a "dedicated schema for X1E80100"? Isn't it "the > schema for all multi-bus controllers"? > > I.e. isn't this a "dedicated schema for all platforms starting with > SM8450"? Suggestion was from Krzysztof to add platform specific comaptible (and therefore schema). Since the first platform that will support in upstream proper multi bus is the x1e80100, the schema needs to bear the same name as the compatible. When support for multi bus will be added to the other platforms (including the SM8450), they will use the fallback compatible of the x1e80100 and will be documented in this newly added schema. We did the same thing with some PHYs drivers, IIRC. > > Can you please use the commit message to document the actual reason why > you choose to create a dedicated schema for this? Is it simply to avoid > having to schema with either pmics or multiple buses as children? I can re-send the patchset with such a phrase in commit message. One of the early versions of this patchset was actually submitting a generic compatible for multi bus, but I remember that there was a request for following the platform dedicated approach. Krzysztof, can you please provide here the argument for why that is preferred? > > Regards, > Bjorn