From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4BDD014D458 for ; Thu, 11 Apr 2024 14:16:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712844986; cv=none; b=p2UNFE+5L6fcS7zWtLUvfOCmVF9+oeL6OmkIE7/tp/fGUjIDSTStUC9kJaPMsmlDbogK+ZGKtyI1ywBLpLp2H1MYG5nGVFiJRcghUsNI/rvg670pLm/H6htTgjmzlGrprUqQjfluFUOlyDUXmBK+x4fD5IZv2K0WKNcn6TudTaQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712844986; c=relaxed/simple; bh=9eDUfFpsnSByPAqcPCwyufcI3DhKvyJo1MAFTfMH4VE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IaMumol/fE5D6mMQSqjfWkBVQvz+bmoBSAxZbUlEXzwtG5eTetOSnNmJCs15qI//TmDdAVB8GeQ2PT3v6Rtn5HdG0CVoLWKDgFjNvnqUnRvaspDYaJjBi/ZfG9tPXJX7aSxpaDHye7NQGT0b0Jl7rVyEHuY5wmJez2UJS+HSOyQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3FBC7339; Thu, 11 Apr 2024 07:16:54 -0700 (PDT) Received: from e133380.arm.com (e133380.arm.com [10.1.197.52]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E0AB43F64C; Thu, 11 Apr 2024 07:16:21 -0700 (PDT) Date: Thu, 11 Apr 2024 15:16:19 +0100 From: Dave Martin To: Reinette Chatre Cc: James Morse , x86@kernel.org, linux-kernel@vger.kernel.org, Fenghua Yu , Thomas Gleixner , Ingo Molnar , Borislav Petkov , H Peter Anvin , Babu Moger , shameerali.kolothum.thodi@huawei.com, D Scott Phillips OS , carl@os.amperecomputing.com, lcherian@marvell.com, bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com, baolin.wang@linux.alibaba.com, Jamie Iles , Xin Hao , peternewman@google.com, dfustini@baylibre.com, amitsinght@marvell.com, David Hildenbrand , Rex Nie Subject: Re: [PATCH v1 14/31] x86/resctrl: Export the is_mbm_*_enabled() helpers to asm/resctrl.h Message-ID: References: <20240321165106.31602-1-james.morse@arm.com> <20240321165106.31602-15-james.morse@arm.com> <67021f34-65fd-4ea8-b696-b5d797ae9dbc@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <67021f34-65fd-4ea8-b696-b5d797ae9dbc@intel.com> On Mon, Apr 08, 2024 at 08:20:12PM -0700, Reinette Chatre wrote: > Hi James, > > On 3/21/2024 9:50 AM, James Morse wrote: > > The architecture specific parts of resctrl have helpers to hide accesses > > to the rdt_mon_features bitmap. > > > > Once the filesystem parts of resctrl are moved, these can no longer live > > in internal.h. Once these are exposed to the wider kernel, they should > > have a 'resctrl_arch_' prefix, to fit the rest of the arch<->fs interface. > > > > Move and rename the helpers that touch rdt_mon_features directly. > > is_mbm_event() and is_mbm_enabled() are only called from rdtgroup.c, > > so can be moved into that file. > > > > Signed-off-by: James Morse > > --- > > arch/x86/include/asm/resctrl.h | 17 +++++++++++ > > arch/x86/kernel/cpu/resctrl/core.c | 4 +-- > > arch/x86/kernel/cpu/resctrl/internal.h | 27 ----------------- > > arch/x86/kernel/cpu/resctrl/monitor.c | 18 ++++++------ > > arch/x86/kernel/cpu/resctrl/rdtgroup.c | 40 +++++++++++++++++--------- > > 5 files changed, 54 insertions(+), 52 deletions(-) > > > > diff --git a/arch/x86/include/asm/resctrl.h b/arch/x86/include/asm/resctrl.h > > index 5f6a5375bb4a..50407e83d0ca 100644 > > --- a/arch/x86/include/asm/resctrl.h > > +++ b/arch/x86/include/asm/resctrl.h > > @@ -7,6 +7,7 @@ > > #include > > #include > > #include > > +#include > > > > Can this be alphabetical? I'd guess so, looking at it. Noted. Cheers ---Dave