From: Jules Irenge <jbi.octave@gmail.com>
To: mingo@redhat.com
Cc: tglx@linutronix.de, bp@alien8.de, x86@kernel.org, hpa@zytor.com,
peterz@infradead.org, rdunlap@infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] x86/tsc: Use div64_ul instead of do_div()
Date: Sun, 28 Apr 2024 18:32:15 +0100 [thread overview]
Message-ID: <Zi6IHzCyyaY2IZNx@octinomon.home> (raw)
do_div() truncates a u64 divisor to 32 bit.
This can lead to non-zero being truncated to zero for division.
Fix coccinelle warning
WARNING: do_div() does a 64-by-32 division, please consider using div64_ul instead
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
arch/x86/kernel/tsc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
index 2da37f33dd17..2ed154a2642c 100644
--- a/arch/x86/kernel/tsc.c
+++ b/arch/x86/kernel/tsc.c
@@ -823,7 +823,7 @@ static unsigned long pit_hpet_ptimer_calibrate_cpu(void)
/* Check the reference deviation */
delta = ((u64) tsc_pit_min) * 100;
- do_div(delta, tsc_ref_min);
+ div64_ul(delta, tsc_ref_min);
/*
* If both calibration results are inside a 10% window
--
2.43.2
reply other threads:[~2024-04-28 17:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zi6IHzCyyaY2IZNx@octinomon.home \
--to=jbi.octave@gmail.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®