From: Frank Li <Frank.li@nxp.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: "Krzysztof Wilczyński" <kw@linux.com>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
"Niklas Cassel" <cassel@kernel.org>
Subject: Re: [PATCH v2 2/2] PCI: endpoint: pci-epf-test: Use 'msix_capable' flag directly in pci_epf_test_alloc_space()
Date: Thu, 18 Apr 2024 09:49:02 -0400 [thread overview]
Message-ID: <ZiEkzrwelbYCFO5P@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20240418-pci-epf-test-fix-v2-2-eacd54831444@linaro.org>
On Thu, Apr 18, 2024 at 01:29:59PM +0530, Manivannan Sadhasivam wrote:
> Instead of using a local variable to cache the 'msix_capable' flag, use it
> directly to simplify the code.
Reviewed-by: Frank Li <Frank.Li@nxp.com>
>
> Suggested-by: Niklas Cassel <cassel@kernel.org>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> drivers/pci/endpoint/functions/pci-epf-test.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c
> index 546d2a27955c..3de18a601e7b 100644
> --- a/drivers/pci/endpoint/functions/pci-epf-test.c
> +++ b/drivers/pci/endpoint/functions/pci-epf-test.c
> @@ -802,19 +802,15 @@ static int pci_epf_test_alloc_space(struct pci_epf *epf)
> size_t msix_table_size = 0;
> size_t test_reg_bar_size;
> size_t pba_size = 0;
> - bool msix_capable;
> void *base;
> enum pci_barno test_reg_bar = epf_test->test_reg_bar;
> enum pci_barno bar;
> - const struct pci_epc_features *epc_features;
> + const struct pci_epc_features *epc_features = epf_test->epc_features;
> size_t test_reg_size;
>
> - epc_features = epf_test->epc_features;
> -
> test_reg_bar_size = ALIGN(sizeof(struct pci_epf_test_reg), 128);
>
> - msix_capable = epc_features->msix_capable;
> - if (msix_capable) {
> + if (epc_features->msix_capable) {
> msix_table_size = PCI_MSIX_ENTRY_SIZE * epf->msix_interrupts;
> epf_test->msix_table_offset = test_reg_bar_size;
> /* Align to QWORD or 8 Bytes */
>
> --
> 2.25.1
>
prev parent reply other threads:[~2024-04-18 13:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 7:59 [PATCH v2 0/2] PCI: endpoint: pci-epf-test: Cleanup the usage of 'pci_epf_test::epc_features' Manivannan Sadhasivam
2024-04-18 7:59 ` [PATCH v2 1/2] PCI: endpoint: pci-epf-test: Make use of cached 'epc_features' in pci_epf_test_core_init() Manivannan Sadhasivam
2024-04-18 8:29 ` Niklas Cassel
2024-04-18 13:48 ` Frank Li
2024-05-17 11:06 ` Krzysztof Wilczyński
2024-04-18 7:59 ` [PATCH v2 2/2] PCI: endpoint: pci-epf-test: Use 'msix_capable' flag directly in pci_epf_test_alloc_space() Manivannan Sadhasivam
2024-04-18 8:29 ` Niklas Cassel
2024-04-18 13:49 ` Frank Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZiEkzrwelbYCFO5P@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®