mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 04/12] regulator/core: regulator_bulk_get: remove redundant NULL stores
Date: Tue, 30 Apr 2024 01:01:28 +0900	[thread overview]
Message-ID: <Zi_EWBtMFISQJcHE@finisterre.sirena.org.uk> (raw)
In-Reply-To: <1ec1a8090c0e316ee005629c24f2779211e0aebf.1714399603.git.mirq-linux@rere.qmqm.pl>

[-- Attachment #1: Type: text/plain, Size: 354 bytes --]

On Mon, Apr 29, 2024 at 04:45:28PM +0200, Michał Mirosław wrote:
> On error, callers of regulator_bulk_get() pass the error up and don't
> use the pointers in consumers[]. The function is documented to release
> all regulators if any request fails.

This doesn't seem good from a robustness point of view and should be
nowhere near a fast path.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2024-04-29 16:01 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-29 14:45 [PATCH v2 00/12] regulator/core: Trivial cleanups and improvements Michał Mirosław
2024-04-29 14:45 ` [PATCH v2 02/12] regulator/core: set_consumer_device_supply: remove `has_dev` Michał Mirosław
2024-04-29 14:45 ` [PATCH v2 01/12] regulator/core: _regulator_get: simplify error returns Michał Mirosław
2024-04-29 14:45 ` [PATCH v2 04/12] regulator/core: regulator_bulk_get: remove redundant NULL stores Michał Mirosław
2024-04-29 16:01   ` Mark Brown [this message]
2024-05-01 10:55     ` Michał Mirosław
2024-04-29 14:45 ` [PATCH v2 03/12] regulator/core: of_get_child_regulator: remove goto Michał Mirosław
2024-04-29 14:45 ` [PATCH v2 06/12] regulator/core: remove regulator_init callback Michał Mirosław
2024-04-29 14:45 ` [PATCH v2 05/12] regulator/core: regulator_ena_gpio_ctrl: pull in ena_gpio state handling Michał Mirosław
2024-04-29 14:45 ` [PATCH v2 08/12] regulator/core: set_consumer_device_supply: avoid copying const data Michał Mirosław
2024-04-29 14:45 ` [PATCH v2 07/12] regulator/core: remove regulator_get_init_drvdata() Michał Mirosław
2024-04-29 14:45 ` [PATCH v2 09/12] regulator/tps68470: use rdev_get_drvdata() Michał Mirosław
2024-04-29 14:45 ` [PATCH v2 11/12] regulator/core: remove regulator_get/set_drvdata Michał Mirosław
2024-04-29 14:45 ` [PATCH v2 10/12] regulator/core: use dev_to_rdev() for device -> regulator_dev cast Michał Mirosław
2024-04-29 14:45 ` [PATCH v2 12/12] regulator/core: use rdev->dev.driver_data Michał Mirosław
2024-04-30  2:54   ` kernel test robot
2024-04-30  4:53   ` kernel test robot
2024-05-01 11:11     ` Michał Mirosław

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zi_EWBtMFISQJcHE@finisterre.sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mirq-linux@rere.qmqm.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®