Re: [PATCH 6.1 000/141] 6.1.88-rc1 review

[Pavel Machek <pavel@denx.de>]

[-- Attachment #1: Type: text/plain, Size: 4023 bytes --]

Hi!

> This is the start of the stable review cycle for the 6.1.88 release.
> There are 141 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.

This causes compilation errors in our testing:

arch/arm/mach-omap2/pdata-quirks.c:259:15: error: variable 'pandora_soc_audio_gpios' has initializer but incomplete type
1991  259 | static struct gpiod_lookup_table pandora_soc_audio_gpios = {
1992      |               ^~~~~~~~~~~~~~~~~~
1993arch/arm/mach-omap2/pdata-quirks.c:260:10: error: 'struct gpiod_lookup_table' has no member named 'dev_id'
1994  260 |         .dev_id = "soc-audio",
1995      |          ^~~~~~
1996arch/arm/mach-omap2/pdata-quirks.c:260:19: warning: excess elements in struct initializer
1997  260 |         .dev_id = "soc-audio",
1998      |                   ^~~~~~~~~~~
1999arch/arm/mach-omap2/pdata-quirks.c:260:19: note: (near initialization for 'pandora_soc_audio_gpios')
2000arch/arm/mach-omap2/pdata-quirks.c:261:10: error: 'struct gpiod_lookup_table' has no member named 'table'
2001  261 |         .table = {
2002      |          ^~~~~
2003arch/arm/mach-omap2/pdata-quirks.c:261:18: error: extra brace group at end of initializer
2004  261 |         .table = {
2005      |                  ^
2006arch/arm/mach-omap2/pdata-quirks.c:261:18: note: (near initialization for 'pandora_soc_audio_gpios')
2007arch/arm/mach-omap2/pdata-quirks.c:262:17: error: implicit declaration of function 'GPIO_LOOKUP'; did you mean 'IOP_LOOKUP'? [-Werror=implicit-function-declaration]
2008  262 |                 GPIO_LOOKUP("gpio-112-127", 6, "dac", GPIO_ACTIVE_HIGH),
2009      |                 ^~~~~~~~~~~
2010      |                 IOP_LOOKUP
2011arch/arm/mach-omap2/pdata-quirks.c:262:55: error: 'GPIO_ACTIVE_HIGH' undeclared here (not in a function); did you mean 'ACPI_ACTIVE_HIGH'?
2012  262 |                 GPIO_LOOKUP("gpio-112-127", 6, "dac", GPIO_ACTIVE_HIGH),
2013      |                                                       ^~~~~~~~~~~~~~~~
2014      |                                                       ACPI_ACTIVE_HIGH
2015arch/arm/mach-omap2/pdata-quirks.c:264:17: error: extra brace group at end of initializer
2016  264 |                 { }
2017      |                 ^
2018arch/arm/mach-omap2/pdata-quirks.c:264:17: note: (near initialization for 'pandora_soc_audio_gpios')
2019arch/arm/mach-omap2/pdata-quirks.c:261:18: warning: excess elements in struct initializer
2020  261 |         .table = {
2021      |                  ^
2022arch/arm/mach-omap2/pdata-quirks.c:261:18: note: (near initialization for 'pandora_soc_audio_gpios')
2023  CC      net/sched/sch_api.o
2024arch/arm/mach-omap2/pdata-quirks.c: In function 'omap3_pandora_legacy_init':
2025arch/arm/mach-omap2/pdata-quirks.c:271:9: error: implicit declaration of function 'gpiod_add_lookup_table' [-Werror=implicit-function-declaration]
2026  271 |         gpiod_add_lookup_table(&pandora_soc_audio_gpios);
2027      |         ^~~~~~~~~~~~~~~~~~~~~~
2028arch/arm/mach-omap2/pdata-quirks.c: At top level:
2029arch/arm/mach-omap2/pdata-quirks.c:259:34: error: storage size of 'pandora_soc_audio_gpios' isn't known
2030  259 | static struct gpiod_lookup_table pandora_soc_audio_gpios = {
2031      |                                  ^~~~~~~~~~~~~~~~~~~~~~~
2032cc1: some warnings being treated as errors
2033make[2]: *** [scripts/Makefile.build:250: arch/arm/mach-omap2/pdata-quirks.o] Error 1
2034make[1]: *** [scripts/Makefile.build:500: arch/arm/mach-omap2] Error 2
2035make[1]: *** Waiting for unfinished jobs....
2036

https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/jobs/6700371466
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/pipelines/1265143103

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]