From: Richard Cochran <richardcochran@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Mahesh Bandewar <maheshb@google.com>,
Netdev <netdev@vger.kernel.org>,
Linux <linux-kernel@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
Sagi Maimon <maimon.sagi@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
John Stultz <jstultz@google.com>,
Mahesh Bandewar <mahesh@bandewar.net>
Subject: Re: [PATCHv4 net-next] ptp/ioctl: support MONOTONIC_RAW timestamps for PTP_SYS_OFFSET_EXTENDED
Date: Thu, 9 May 2024 21:07:00 -0700 [thread overview]
Message-ID: <Zj2dZJAfOdag-M1H@hoboy.vegasvil.org> (raw)
In-Reply-To: <87cypwpxbh.ffs@tglx>
Thomas,
On Wed, May 08, 2024 at 09:38:58AM +0200, Thomas Gleixner wrote:
> On Tue, May 07 2024 at 21:44, Richard Cochran wrote:
> > On Thu, May 02, 2024 at 02:10:47PM -0700, Mahesh Bandewar wrote:
> >> + * History:
> >> + * v1: Initial implementation.
> >> + *
> >> + * v2: Use the first word of the reserved-field for @clockid. That's
> >> + * backward compatible since v1 expects all three reserved words
> >> + * (@rsv[3]) to be 0 while the clockid (first word in v2) for
> >> + * CLOCK_REALTIME is '0'.
...
> I agree that it wants to be in the commit message, but having the
> version information in the kernel-doc which describes the UAPI is
> sensible and useful. That's where I'd look first and asking a user to
> dig up this information on lore is not really helpful.
But writing "v1, v2" doesn't make sense for this code. There never
was a "v1" for this ioctl. At the very least, the change should be
identified by kernel version (or git SHA).
Thanks,
Richard
next prev parent reply other threads:[~2024-05-10 4:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 21:10 Mahesh Bandewar
2024-05-07 8:42 ` Paolo Abeni
2024-05-08 4:44 ` Richard Cochran
2024-05-08 7:38 ` Thomas Gleixner
2024-05-10 4:07 ` Richard Cochran [this message]
2024-05-10 7:50 ` Thomas Gleixner
2024-05-10 16:45 ` Mahesh Bandewar (महेश बंडेवार)
2024-05-11 9:59 ` Thomas Gleixner
2024-05-09 2:48 ` Mahesh Bandewar (महेश बंडेवार)
2024-05-08 7:35 ` Thomas Gleixner
2024-05-09 2:53 ` Mahesh Bandewar (महेश बंडेवार)
2024-05-10 21:27 ` Yuliang Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zj2dZJAfOdag-M1H@hoboy.vegasvil.org \
--to=richardcochran@gmail.com \
--cc=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jstultz@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mahesh@bandewar.net \
--cc=maheshb@google.com \
--cc=maimon.sagi@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®