From: Andy Shevchenko <andy@black.fi.intel.com>
To: linux-kernel@vger.kernel.org
Cc: linux-tip-commits@vger.kernel.org, Levi Yun <ppbuk5246@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Anna-Maria Behnsen <anna-maria@linutronix.de>,
x86@kernel.org
Subject: Re: [tip: timers/urgent] timers/migration: Prevent out of bounds access on failure
Date: Wed, 8 May 2024 12:57:11 +0300 [thread overview]
Message-ID: <ZjtMdx8v051qcNtU@black.fi.intel.com> (raw)
In-Reply-To: <171516154125.10875.14125964308560203288.tip-bot2@tip-bot2>
On Wed, May 08, 2024 at 09:45:41AM -0000, tip-bot2 for Levi Yun wrote:
> The following commit has been merged into the timers/urgent branch of tip:
(Yes, I noted above)
...
> - do {
> + while (i > 0) {
> group = stack[--i];
Looking at this and most used patterns for cleanup loops, I would amend
this to
while (i--) {
group = stack[i];
which seems to me an equivalent.
> if (err < 0) {
> @@ -1645,7 +1645,7 @@ static int tmigr_setup_groups(unsigned int cpu, unsigned int node)
> tmigr_connect_child_parent(child, group);
> }
> }
> - } while (i > 0);
> + }
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-05-08 9:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 19:51 [PATCH] time/timgr: Fix wrong reference when level 0 group allocation failed Levi Yun
2024-05-04 4:47 ` Yun Levi
2024-05-04 10:09 ` Markus Elfring
2024-05-05 8:57 ` [PATCH RESEND] " Levi Yun
2024-05-05 10:23 ` Markus Elfring
2024-05-05 10:55 ` Yun Levi
2024-05-05 10:54 ` [PATCH v2] " Levi Yun
2024-05-05 17:07 ` [v2] " Markus Elfring
2024-05-06 4:10 ` [PATCH v3] " Levi Yun
2024-05-06 10:10 ` Frederic Weisbecker
2024-05-08 6:16 ` Anna-Maria Behnsen
2024-05-08 6:38 ` [v3] " Markus Elfring
2024-05-08 9:45 ` [tip: timers/urgent] timers/migration: Prevent out of bounds access on failure tip-bot2 for Levi Yun
2024-05-08 9:57 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjtMdx8v051qcNtU@black.fi.intel.com \
--to=andy@black.fi.intel.com \
--cc=anna-maria@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=ppbuk5246@gmail.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome