From: Frank Li <Frank.li@nxp.com>
To: linux@treblig.org
Cc: vkoul@kernel.org, linux-arm-msm@vger.kernel.org,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: qcom: gpi: remove unused struct 'gpi_desc'
Date: Thu, 16 May 2024 10:49:50 -0400 [thread overview]
Message-ID: <ZkYdDtoPMnYlGT/6@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20240516133211.251205-1-linux@treblig.org>
On Thu, May 16, 2024 at 02:32:11PM +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> 'gpi_desc' seems like it was never used.
> Remove it.
code change show 'reg_info', not 'gpi_desc'. You need make sure that it
really is not used, not "seems like".
'struct reg_info' is never used, so remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
> drivers/dma/qcom/gpi.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
> index 1c93864e0e4d..639ab304db9b 100644
> --- a/drivers/dma/qcom/gpi.c
> +++ b/drivers/dma/qcom/gpi.c
> @@ -476,12 +476,6 @@ struct gpi_dev {
> struct gpii *gpiis;
> };
>
> -struct reg_info {
> - char *name;
> - u32 offset;
> - u32 val;
> -};
> -
> struct gchan {
> struct virt_dma_chan vc;
> u32 chid;
> --
> 2.45.0
>
next prev parent reply other threads:[~2024-05-16 14:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-16 13:32 linux
2024-05-16 14:49 ` Frank Li [this message]
2024-05-16 15:25 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZkYdDtoPMnYlGT/6@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@treblig.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®