From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: kernel-janitors@vger.kernel.org,
Chanwoo Choi <cw00.choi@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Stanley Chang <stanley_chang@realtek.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] extcon: realtek: Use scope-based resource management in extcon_rtk_type_c_init()
Date: Wed, 5 Jun 2024 00:11:34 +0300 [thread overview]
Message-ID: <Zl-DBkt8sNb9xypq@smile.fi.intel.com> (raw)
In-Reply-To: <532aa50e-b8e5-4e8e-a2bd-a05fd81274dc@web.de>
On Tue, Jun 04, 2024 at 10:06:14PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 4 Jun 2024 21:55:08 +0200
>
> Scope-based resource management became supported also for another
> programming interface by contributions of Jonathan Cameron on 2024-02-17.
> See also the commit 59ed5e2d505bf5f9b4af64d0021cd0c96aec1f7c ("device
> property: Add cleanup.h based fwnode_handle_put() scope based cleanup.").
>
> * Thus use the attribute “__free(fwnode_handle)”.
>
> * Reduce the scope for the local variable “fwnode”.
> Fixes: 8a590d7371f0 ("extcon: add Realtek DHC RTD SoC Type-C driver")
The problem here is that the above mentioned API only recently appeared in the
kernel. It will be impossible to backport without backporting a new API, which
is usually contradicts the idea of stable kernels. That's why it's better to
really fix without using a new APIs and then convert to a new one. Hence needs
two patches.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-06-04 21:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 20:06 Markus Elfring
2024-06-04 21:11 ` Andy Shevchenko [this message]
2024-06-29 9:44 ` [PATCH v2] extcon: realtek: Prevent resource leak " Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zl-DBkt8sNb9xypq@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Markus.Elfring@web.de \
--cc=cw00.choi@samsung.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=stanley_chang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®