From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1AD813CABB for ; Tue, 4 Jun 2024 21:46:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717537569; cv=none; b=dD0NGQiq6Cr/S5yPCMVhcSI4pZmNK97vUh3AnyQpbyCDIq+8flCOCt1IQOONn9J5wweeCk2XgulYk+3SHT8v9vJaVTphEnMNY1mPLH+u+Xm7H3peZlmKQ9X7rsd28d1B1bqCU9KXuwojAuSELFsCiD7xKRkzGRBvWcSB2Nz/4Lg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717537569; c=relaxed/simple; bh=p50tzagc22lV4uZC19romum3y3Oh2dqEujTGg+i+WVk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FzgPS8e9ide/qVJG9kzDJAgh+ZB42LiCTdQMRaMk7zv6KaBtMyx/5DUeOT5S0JhhMmU26C9qCWy7VVNBR7LUMXhLh40KBjcIw+ZBTkS9AB9h2u+55eh6ALI+mieN2JPED1ClKNNF1pMi++5YcOPWG6ewm+P/UOP/E3y7lgqinAw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=GK3GY3A9; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="GK3GY3A9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1717537564; x=1749073564; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=p50tzagc22lV4uZC19romum3y3Oh2dqEujTGg+i+WVk=; b=GK3GY3A9ljZP639KHChSmTObyieFPHOs4a+cClnd89B3sEsTMePqhQtB iXLxjokI7/tN4tHdZwDhMyFMs3uWu/OLC32CULGCCrIlMl9hfmwgm3AcT KBNgbozPnwf8UJLlC7OXUa6tQ0NIaH0aoBHl3vOTVwujukjUAz0BN8dC1 /dkWPYTG5QkSJe/e6wcHj6dYjEVSpnC6n3GsGYMK4VHdjiFi43PbAZKmO hcXwGWHFeU2GolUjs+C6Phu2VPt6JTpI3AETF/IUxrKvjGIwwhZJaf6u0 kW2wJg0ZhDow3CDAtm3btF+FJBFLB99SL0R7Akf52NLGb1K86q5Yy3ywV w==; X-CSE-ConnectionGUID: 0D+zsaT/QcOWEFY1mu4Cwg== X-CSE-MsgGUID: /RexKBUJQL2rDMxpJtdUjw== X-IronPort-AV: E=McAfee;i="6600,9927,11093"; a="25520793" X-IronPort-AV: E=Sophos;i="6.08,214,1712646000"; d="scan'208";a="25520793" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2024 14:46:04 -0700 X-CSE-ConnectionGUID: jKhLV0Z0S1KeE73nPNNA3Q== X-CSE-MsgGUID: C1zmRyItRESZP6ATtGXQ5w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,214,1712646000"; d="scan'208";a="41798995" Received: from smile.fi.intel.com ([10.237.72.54]) by fmviesa005.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2024 14:46:01 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1sEbyg-0000000Dfi6-3nyw; Wed, 05 Jun 2024 00:45:58 +0300 Date: Wed, 5 Jun 2024 00:45:58 +0300 From: Andy Shevchenko To: Chia-I Wu Cc: Greg Kroah-Hartman , Andrew Morton , AKASHI Takahiro , Dan Williams , Baoquan He , Alison Schofield , linux-kernel@vger.kernel.org Subject: Re: [PATCH] resource: add a basic test for walk_iomem_res_desc Message-ID: References: <20240604213200.672279-1-olvaffe@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Wed, Jun 05, 2024 at 12:38:27AM +0300, Andy Shevchenko wrote: > On Tue, Jun 04, 2024 at 02:31:46PM -0700, Chia-I Wu wrote: ... > > + res[2] = (struct resource){ > > + .start = offset, > > + .end = offset + SZ_1K - 1, > > + .name = "NESTED", > > + }; > > We have respective macros. Use them. And use explicitly hardocded start in all of them instead of coding += for offset variable. For the test cases is better when data is hardcoded, esp. when it's an expected result (just to mention, here it seems an input data). -- With Best Regards, Andy Shevchenko