From: Sean Christopherson <seanjc@google.com>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: x86: add missing MODULE_DESCRIPTION() macros
Date: Mon, 3 Jun 2024 16:09:39 -0700 [thread overview]
Message-ID: <Zl5NM5S4Trrqog_t@google.com> (raw)
In-Reply-To: <20240528-md-kvm-v1-1-c1b86f0f5112@quicinc.com>
On Tue, May 28, 2024, Jeff Johnson wrote:
> Fix the following allmodconfig 'make W=1' warnings when building for x86:
> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/x86/kvm/kvm.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/x86/kvm/kvm-intel.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/x86/kvm/kvm-amd.o
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> arch/x86/kvm/svm/svm.c | 1 +
> arch/x86/kvm/vmx/vmx.c | 1 +
> virt/kvm/kvm_main.c | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c
> index c8dc25886c16..bdd39931720c 100644
> --- a/arch/x86/kvm/svm/svm.c
> +++ b/arch/x86/kvm/svm/svm.c
> @@ -53,6 +53,7 @@
> #include "svm_onhyperv.h"
>
> MODULE_AUTHOR("Qumranet");
> +MODULE_DESCRIPTION("KVM SVM (AMD-V) extensions");
How about "KVM support for SVM (AMD-V) extensions"?
> MODULE_LICENSE("GPL");
>
> #ifdef MODULE
> diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
> index 6051fad5945f..956e6062f311 100644
> --- a/arch/x86/kvm/vmx/vmx.c
> +++ b/arch/x86/kvm/vmx/vmx.c
> @@ -74,6 +74,7 @@
> #include "posted_intr.h"
>
> MODULE_AUTHOR("Qumranet");
> +MODULE_DESCRIPTION("KVM VMX (Intel VT-x) extensions");
And then a similar thing here.
> MODULE_LICENSE("GPL");
>
> #ifdef MODULE
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 14841acb8b95..b03d06ca29c4 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -74,6 +74,7 @@
> #define ITOA_MAX_LEN 12
>
> MODULE_AUTHOR("Qumranet");
> +MODULE_DESCRIPTION("Kernel-based Virtual Machine driver for Linux");
Maybe "Kernel-based Virtual Machine (KVM) Hypervisor"? I personally never think
of KVM as a "driver", though I know it's been called that in the past. And having
"Hypervisor" in the name might help unfamiliar users.
next prev parent reply other threads:[~2024-06-03 23:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 20:06 Jeff Johnson
2024-06-03 23:09 ` Sean Christopherson [this message]
2024-06-03 23:21 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zl5NM5S4Trrqog_t@google.com \
--to=seanjc@google.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=quic_jjohnson@quicinc.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®