From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FCC3176AD2; Thu, 30 May 2024 08:08:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717056480; cv=none; b=d0Ib0/BE9YpLb7oEniJMgkxFTmbHMzAZx8oNB/ySCV6wf5xaArubd7k3Y1FNjHKNwUk8clj7LpoImKZx0EEZL1gZhS20NI/h3BMEcNuyqImcjo6jcgsTp5GSEo9i9344hj15kQ47ykwBcVC1AlOXAesadqAyvn9tpEwD+0nv4SM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717056480; c=relaxed/simple; bh=w3n/45oEbfFxqAimcpQO8TVqfQH0H9GcJTD+Mjl8Uws=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=D3i24oARTvVji0EYkVfeBegea1fPx2sXqebE4NoJqIbpYLvL378ufqy/EZjprD5BOPA7M+Jf6uc/YJWMg5j3N/fQ88cHTGKwP5rNJecH9Q2HqK/6AkAmZ74m2UGcnF13WugnHs459aWTlK0wZkfUUvp4nmP9Ksd7U+3pWsh/iWE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QVZjzg/B; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QVZjzg/B" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EBCF6C2BBFC; Thu, 30 May 2024 08:07:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717056480; bh=w3n/45oEbfFxqAimcpQO8TVqfQH0H9GcJTD+Mjl8Uws=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QVZjzg/BAZiQfiiRbD6Qnn+nr/J4kHDWwHOuGGXaQ7T0c2FqPKxSm8/+MOVVZ2Rl4 h3rGiyv/30nVz38en6eL9wOF2Y7r81592fYEEP+VYzdgMA34WO5vquzfFUJdBDRJPN nc/wB6n9uW2gRyCiu+Z3t5xa3e2zssCiXEJy/KkaVxsH4XcTdkvMQF9/9uY8R6UxEp wiJph6hi9dTWGhqPFxfn1uQ0G2MCh+CEw14P1vdZ/RcQz+WLexI0jAZzJM8rnQjMnu mcra1kbWhcbWxe9KVipWDqYbBKtZKXKWbeFOq8jIW6EL+ieg1B7eIEptH4/VGU6k8g Etj13hWw9nkqA== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1sCapK-0000000041N-3p0D; Thu, 30 May 2024 10:07:59 +0200 Date: Thu, 30 May 2024 10:07:58 +0200 From: Johan Hovold To: Andy Shevchenko Cc: Johan Hovold , Lee Jones , Mark Brown , Linus Walleij , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Liam Girdwood , Das Srinagesh , Satya Priya Kakitapalli , Stephen Boyd , Bryan O'Donoghue , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH v2 03/14] mfd: pm8008: deassert reset on probe Message-ID: References: <20240529162958.18081-1-johan+linaro@kernel.org> <20240529162958.18081-4-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, May 29, 2024 at 10:45:40PM +0300, Andy Shevchenko wrote: > On Wed, May 29, 2024 at 7:30 PM Johan Hovold wrote: > > > > Request and deassert any (optional) reset gpio during probe in case it > > has been left asserted by the boot firmware. > > > > Note the reset line is not asserted to avoid reverting to the default > > I2C address in case the firmware has configured an alternate address. > > ... > > > + /* > > + * The PMIC does not appear to require a post-reset delay, but wait > > + * for a millisecond for now anyway. > > + */ > > > + usleep_range(1000, 2000); > > fsleep() ? No, I'd only use fsleep() when the argument is variable. Johan