From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
Linus Walleij <linus.walleij@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Dvorkin Dmitry <dvorkin@tibbo.com>,
Wells Lu <wellslutw@gmail.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Emil Renner Berthing <kernel@esmil.dk>,
Jianlong Huang <jianlong.huang@starfivetech.com>,
Hal Feng <hal.feng@starfivetech.com>,
Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
Viresh Kumar <vireshk@kernel.org>,
Shiraz Hashim <shiraz.linux.kernel@gmail.com>,
soc@kernel.org, Krzysztof Kozlowski <krzk@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Patrice Chotard <patrice.chotard@foss.st.com>,
Heiko Stuebner <heiko@sntech.de>,
Damien Le Moal <dlemoal@kernel.org>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
Dong Aisheng <aisheng.dong@nxp.com>,
Fabio Estevam <festevam@gmail.com>,
Shawn Guo <shawnguo@kernel.org>, Jacky Bai <ping.bai@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Chester Lin <chester62515@gmail.com>,
Matthias Brugger <mbrugger@suse.com>,
Ghennadi Procopciuc <ghennadi.procopciuc@oss.nxp.com>,
Sean Wang <sean.wang@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
Joel Stanley <joel@jms.id.au>,
Dan Carpenter <dan.carpenter@linaro.org>,
Tony Lindgren <tony@atomide.com>,
Stephen Warren <swarren@wwwdotorg.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-samsung-soc@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
linux-rockchip@lists.infradead.org,
linux-riscv@lists.infradead.org,
linux-mediatek@lists.infradead.org, imx@lists.linux.dev,
linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org,
Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH v2 07/20] pinctrl: renesas: Use scope based of_node_put() cleanups
Date: Thu, 30 May 2024 12:02:19 +0300 [thread overview]
Message-ID: <ZlhAm-giX6jNaUKr@surfacebook.localdomain> (raw)
In-Reply-To: <CAMuHMdUD=1rpns_mLF2rMM-x5EnOK7TExaJxoJVkbXjVz1H8uQ@mail.gmail.com>
Mon, May 13, 2024 at 01:59:03PM +0200, Geert Uytterhoeven kirjoitti:
> On Sat, May 4, 2024 at 3:14 PM Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote:
...
> You missed one trivial conversion, presumably because no error handling
> and thus no of_node_put() is involved?
Nothing is missed. The below is a redundant change.
...
> - for_each_child_of_node(np, child) {
> + for_each_child_of_node_scoped(np, child) {
> if (of_property_count_u32_elems(child, RZN1_PINS_PROP) > 0)
> count++;
> }
>
> If you prefer not to include this
I prefer this not to be included as it will give a misleading signals to the
use of the original API(s).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-05-30 9:02 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-04 13:19 [PATCH v2 00/20] pinctrl: " Peng Fan (OSS)
2024-05-04 13:19 ` [PATCH v2 01/20] pinctrl: ti: iodelay: " Peng Fan (OSS)
2024-05-04 13:20 ` [PATCH v2 02/20] pinctrl: tegra: " Peng Fan (OSS)
2024-05-30 10:46 ` Thierry Reding
2024-05-04 13:20 ` [PATCH v2 03/20] pinctrl: stm32: " Peng Fan (OSS)
2024-05-17 6:11 ` Patrice CHOTARD
2024-05-27 12:56 ` Linus Walleij
2024-05-04 13:20 ` [PATCH v2 04/20] pinctrl: starfive: " Peng Fan (OSS)
2024-05-27 14:25 ` Markus Elfring
2024-05-30 8:41 ` Peng Fan
2024-05-30 9:40 ` [v2 " Markus Elfring
2024-05-04 13:20 ` [PATCH v2 05/20] pinctrl: sprd: " Peng Fan (OSS)
2024-05-04 13:20 ` [PATCH v2 06/20] pinctrl: spear: " Peng Fan (OSS)
2024-05-04 13:20 ` [PATCH v2 07/20] pinctrl: renesas: " Peng Fan (OSS)
2024-05-13 11:59 ` Geert Uytterhoeven
2024-05-13 12:04 ` Peng Fan
2024-05-13 20:51 ` Linus Walleij
2024-05-14 6:35 ` Geert Uytterhoeven
2024-05-14 7:33 ` Linus Walleij
2024-05-14 8:06 ` Geert Uytterhoeven
2024-05-30 9:02 ` Andy Shevchenko [this message]
2024-05-30 9:21 ` Geert Uytterhoeven
2024-05-04 13:20 ` [PATCH v2 08/20] pinctrl: st: " Peng Fan (OSS)
2024-05-17 6:44 ` Patrice CHOTARD
2024-05-27 12:57 ` Linus Walleij
2024-05-30 9:04 ` Andy Shevchenko
2024-05-04 13:20 ` [PATCH v2 09/20] pinctrl: rockchip: " Peng Fan (OSS)
2024-05-04 13:20 ` [PATCH v2 10/20] pinctrl: equilibrium: " Peng Fan (OSS)
2024-05-04 13:20 ` [PATCH v2 11/20] pinctrl: at91: " Peng Fan (OSS)
2024-05-04 13:20 ` [PATCH v2 12/20] pinctrl: s32cc: " Peng Fan (OSS)
2024-05-04 13:20 ` [PATCH v2 13/20] pinctrl: nomadik: " Peng Fan (OSS)
2024-05-04 13:20 ` [PATCH v2 14/20] pinctrl: mediatek: " Peng Fan (OSS)
2024-05-04 13:20 ` [PATCH v2 15/20] pinctrl: freescale: " Peng Fan (OSS)
2024-05-04 13:20 ` [PATCH v2 16/20] pinctrl: bcm: bcm63xx: " Peng Fan (OSS)
2024-05-04 13:20 ` [PATCH v2 17/20] pinctrl: pinconf-generic: " Peng Fan (OSS)
2024-05-04 13:20 ` [PATCH v2 18/20] pinctrl: freescale: mxs: Fix refcount of child Peng Fan (OSS)
2024-05-27 15:56 ` Markus Elfring
2024-05-30 8:44 ` Peng Fan
2024-05-30 9:50 ` [v2 " Markus Elfring
2024-05-30 9:54 ` Peng Fan
2024-05-04 13:20 ` [PATCH v2 19/20] pinctrl: k210: Use scope based of_node_put() cleanups Peng Fan (OSS)
2024-05-04 13:20 ` [PATCH v2 20/20] pinctrl: samsung: " Peng Fan (OSS)
2024-06-26 10:22 ` (subset) " Krzysztof Kozlowski
2024-06-26 10:40 ` Linus Walleij
2024-05-30 11:56 ` [PATCH v2 00/20] pinctrl: " Geert Uytterhoeven
2024-05-31 3:07 ` Peng Fan
2024-05-31 7:06 ` Geert Uytterhoeven
2024-06-18 11:52 ` Peng Fan
2024-06-26 10:02 ` Linus Walleij
2024-06-26 10:20 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZlhAm-giX6jNaUKr@surfacebook.localdomain \
--to=andy.shevchenko@gmail.com \
--cc=aisheng.dong@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=alim.akhtar@samsung.com \
--cc=andrew@codeconstruct.com.au \
--cc=angelogioacchino.delregno@collabora.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=chester62515@gmail.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=dan.carpenter@linaro.org \
--cc=dlemoal@kernel.org \
--cc=dvorkin@tibbo.com \
--cc=festevam@gmail.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=ghennadi.procopciuc@oss.nxp.com \
--cc=hal.feng@starfivetech.com \
--cc=heiko@sntech.de \
--cc=imx@lists.linux.dev \
--cc=jianlong.huang@starfivetech.com \
--cc=joel@jms.id.au \
--cc=jonathanh@nvidia.com \
--cc=kernel@esmil.dk \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-tegra@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=matthias.bgg@gmail.com \
--cc=mbrugger@suse.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=nicolas.ferre@microchip.com \
--cc=openbmc@lists.ozlabs.org \
--cc=orsonzhai@gmail.com \
--cc=patrice.chotard@foss.st.com \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=ping.bai@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=s.nawrocki@samsung.com \
--cc=sean.wang@kernel.org \
--cc=shawnguo@kernel.org \
--cc=shiraz.linux.kernel@gmail.com \
--cc=soc@kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=tony@atomide.com \
--cc=vireshk@kernel.org \
--cc=wellslutw@gmail.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®