From: Herbert Xu <herbert@gondor.apana.org.au>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Olivia Mackall <olivia@selenic.com>,
Michael Buesch <mb@bu3sch.de>, Andrew Morton <akpm@osdl.org>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH 1/1] hwrng: amd - Convert PCIBIOS_* return codes to errnos
Date: Fri, 7 Jun 2024 19:52:59 +0800 [thread overview]
Message-ID: <ZmL0m6xaL9JXb2mu@gondor.apana.org.au> (raw)
In-Reply-To: <20240527132615.14170-1-ilpo.jarvinen@linux.intel.com>
On Mon, May 27, 2024 at 04:26:15PM +0300, Ilpo Järvinen wrote:
> amd_rng_mod_init() uses pci_read_config_dword() that returns PCIBIOS_*
> codes. The return code is then returned as is but amd_rng_mod_init() is
> a module_init() function that should return normal errnos.
>
> Convert PCIBIOS_* returns code using pcibios_err_to_errno() into normal
> errno before returning it.
>
> Fixes: 96d63c0297cc ("[PATCH] Add AMD HW RNG driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---
> drivers/char/hw_random/amd-rng.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2024-06-07 11:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-27 13:26 Ilpo Järvinen
2024-06-07 11:52 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmL0m6xaL9JXb2mu@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=akpm@osdl.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=olivia@selenic.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®