mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chuck Lever <chuck.lever@oracle.com>
To: Peter Oberparleiter <oberpar@linux.ibm.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	allison.henderson@oracle.com
Subject: Re: [PATCH] gcov: add support for GCC 14
Date: Mon, 10 Jun 2024 09:41:19 -0400	[thread overview]
Message-ID: <ZmcCfzJfsKoVvDpA@tissot.1015granger.net> (raw)
In-Reply-To: <20240610092743.1609845-1-oberpar@linux.ibm.com>

On Mon, Jun 10, 2024 at 11:27:43AM +0200, Peter Oberparleiter wrote:
> Using gcov on kernels compiled with GCC 14 results in truncated 16-byte
> long .gcda files with no usable data. To fix this, update GCOV_COUNTERS
> to match the value defined by GCC 14.
> 
> Tested with GCC versions 14.1.0 and 13.2.0.
> 
> Reported-by: Allison Henderson <allison.henderson@oracle.com>
> Reported-by: Chuck Lever III <chuck.lever@oracle.com>
> Signed-off-by: Peter Oberparleiter <oberpar@linux.ibm.com>
> ---
>  kernel/gcov/gcc_4_7.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/kernel/gcov/gcc_4_7.c b/kernel/gcov/gcc_4_7.c
> index 74a4ef1da9ad..fd75b4a484d7 100644
> --- a/kernel/gcov/gcc_4_7.c
> +++ b/kernel/gcov/gcc_4_7.c
> @@ -18,7 +18,9 @@
>  #include <linux/mm.h>
>  #include "gcov.h"
>  
> -#if (__GNUC__ >= 10)
> +#if (__GNUC__ >= 14)
> +#define GCOV_COUNTERS			9
> +#elif (__GNUC__ >= 10)
>  #define GCOV_COUNTERS			8
>  #elif (__GNUC__ >= 7)
>  #define GCOV_COUNTERS			9
> -- 
> 2.40.1
> 

With "gcc (GCC) 14.1.1 20240522 (Red Hat 14.1.1-4)" on Fedora 40:

lines: 58.2% (2350 out of 4036)
functions: 72.2% (197 out of 273)
branches: 35.5% (1037 out of 2923)
calls: 0.0% (0 out of 0)

All were 0% previously.

Tested-by: Chuck Lever <chuck.lever@oracle.com>


-- 
Chuck Lever

  reply	other threads:[~2024-06-10 13:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-10  9:27 Peter Oberparleiter
2024-06-10 13:41 ` Chuck Lever [this message]
2024-06-10 17:45   ` Andrew Morton
2024-06-12  9:14     ` Peter Oberparleiter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZmcCfzJfsKoVvDpA@tissot.1015granger.net \
    --to=chuck.lever@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=allison.henderson@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oberpar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®