From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 964651791F2 for ; Wed, 12 Jun 2024 13:11:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718197897; cv=none; b=TGFRaAlQ2W3h1U6BT6K6grAAvxhHTfO1uyG/rnQnSzTUx8Ja4Hyu0gMN/PtIlmLO11BhBp0X9iO/gzFy/RTjI7kixIomkuoIgr7HsEK1W1OmrZ5Ija3mOP0ZwbF6Y3yTKIhV0QbOleSaenDkADmFcsaM9/RiHDbinhy33n3L9bY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718197897; c=relaxed/simple; bh=czAqBHpoC4R18fkt9IcXsTUqM0PCW2MD+urROxhSelU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YV9Bk7wS/vrw2SEOUirwcSOYi2pWmtRSVh48McomIXgyWTkParOKO1DKp1IzEyQYS/FhC7XWlZgeTPHiu9YSiZ0snaKOPTYUbngAfek3k1LuyJZSReApXpZQlCRC/D9vHqiaTzrQA8uWawsON5a1d84bPJ/c6cqhj8G1WHH+uDY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sHNlE-0000Qm-Qz; Wed, 12 Jun 2024 15:11:32 +0200 Received: from [2a0a:edc0:0:1101:1d::28] (helo=dude02.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sHNlD-001nKm-V2; Wed, 12 Jun 2024 15:11:31 +0200 Received: from sha by dude02.red.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1sHNlD-0084Du-2p; Wed, 12 Jun 2024 15:11:31 +0200 Date: Wed, 12 Jun 2024 15:11:31 +0200 From: Sascha Hauer To: David Lin Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, briannorris@chromium.org, kvalo@kernel.org, francesco@dolcini.it, tsung-hsien.hsieh@nxp.com, Francesco Dolcini Subject: Re: [PATCH v10 2/2] wifi: mwifiex: add host mlme for AP mode Message-ID: References: <20240418060626.431202-1-yu-hao.lin@nxp.com> <20240418060626.431202-3-yu-hao.lin@nxp.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240418060626.431202-3-yu-hao.lin@nxp.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Hi David, On Thu, Apr 18, 2024 at 02:06:26PM +0800, David Lin wrote: > Add host based MLME to enable WPA3 functionalities in AP mode. > This feature required a firmware with the corresponding V2 Key API > support. The feature (WPA3) is currently enabled and verified only > on IW416. Also, verified no regression with change when host MLME > is disabled. > > Signed-off-by: David Lin > Reviewed-by: Francesco Dolcini > --- > > diff --git a/drivers/net/wireless/marvell/mwifiex/uap_cmd.c b/drivers/net/wireless/marvell/mwifiex/uap_cmd.c > index 491e36611909..073c665183b3 100644 > --- a/drivers/net/wireless/marvell/mwifiex/uap_cmd.c > +++ b/drivers/net/wireless/marvell/mwifiex/uap_cmd.c > @@ -72,6 +72,10 @@ int mwifiex_set_secure_params(struct mwifiex_private *priv, > bss_config->key_mgmt = KEY_MGMT_PSK; > } > break; > + case WLAN_AKM_SUITE_SAE: > + bss_config->protocol = PROTOCOL_WPA2; > + bss_config->key_mgmt = KEY_MGMT_SAE; > + break; Shouldn't this be |= PROTOCOL_WPA2 and |= KEY_MGMT_SAE? Clearing the other flags when SAE is enabled looks wrong to me. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |