mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Daniel Wagner <dwagner@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
	Hannes Reinecke <hare@suse.de>,
	linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvmet: always initialize cqe.result
Date: Wed, 12 Jun 2024 11:56:02 -0600	[thread overview]
Message-ID: <ZmnhMkqt7xch_4e-@kbusch-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <20240612-nvmet-always-init-v1-1-0c0fd94461f0@suse.de>

On Wed, Jun 12, 2024 at 04:11:59PM +0200, Daniel Wagner wrote:
> The spec doesn't mandate that the first two double words (aka results)
> for the command queue entry need to be set to 0 when they are not
> used (not specified). Though, the target implemention returns 0 for TCP
> and FC but not for RDMA.
> 
> Let's make RDMA behave the same and thus explicitly initializing the
> result field. This prevents leaking any data from the stack.

Thanks, applied to nvme-6.10.

      parent reply	other threads:[~2024-06-12 17:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-12 14:11 Daniel Wagner
2024-06-12 14:40 ` Christoph Hellwig
2024-06-12 17:56 ` Keith Busch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZmnhMkqt7xch_4e-@kbusch-mbp.dhcp.thefacebook.com \
    --to=kbusch@kernel.org \
    --cc=dwagner@suse.de \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®