From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BDFE136672; Thu, 13 Jun 2024 05:44:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718257465; cv=none; b=qPX39fkgM4twnI03hJ3Cg63DJoTRxn+NzV06OqO7WmrKpbdGK6dVxOeZFcxZEUHaxV2B1ZE4An8hlbKNOrOLSK+5XNiulFudoHVLfvPS+2M55IiS0iieTWUfVSEJ5Lyzd9GuUFA4OAnNkhO/f/9ru/Gn5EWRY8yOuAEuxN2Uo5o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718257465; c=relaxed/simple; bh=/tygySxNptF1bNqqC2R+zD32oTKCFsAxOPINPtnaW6c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VRI0qvtia5MjgIBT59vDB3zAiJuHSqrGtGDK1X1xq72nZWirXRejRr4brz5iA1DaDl6glYF0U0rBHBmZiQVZSBtzUoj/YEqkBec1LL8nikqNYGxHuit/02BX7Pu1Zv2ZrEHv5Wy3It9WQ+0qG/zu+YFWIT4oEJyfpyzPDZCG+8Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=XMBP4Gj4; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="XMBP4Gj4" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mZUyZbGRLoZ61VzFcElkmd0RzIflNIRedkXb41aYIms=; b=XMBP4Gj4alCsQXtnGvwGXhKGJq WcL/CT6vNh91rMWL54YOhyIVKEZ/leEAqL33Ichz8d1gGp+JsGDS2PbQPDoQGZr96bGQqisXqcIsJ OuEO+i9FYIEzwCXV36lgY4XnjcWtzPmXcjWWaOvp5deZ60g/G7q+sKCNsNgeM21GL+aAIXBewlA9h h7mCJ6SESIzFIIHYiPRtM2v1wtHhYFCW9tb+tr/QPY3z0FdPkqJxzfzXUyDeiXOKjmA45C2hTvlD6 Pu3Xx6w3CK5nY7Zfa/zkDicZU9YyKyX9LdVJ28OmMNCTD+BBduLlz0Ooq2RoJ35KLgLW4xgDRHnQ5 /vHY+Ewg==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHdG1-0000000FCio-48U9; Thu, 13 Jun 2024 05:44:21 +0000 Date: Wed, 12 Jun 2024 22:44:21 -0700 From: Christoph Hellwig To: Martin Oliveira Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Jason Gunthorpe , Leon Romanovsky , Greg Kroah-Hartman , Tejun Heo , Andrew Morton , Logan Gunthorpe , Mike Marciniszyn , Shiraz Saleem , Michael Guralnik , Artemy Kovalyov Subject: Re: [PATCH v2 1/4] kernfs: remove page_mkwrite() from vm_operations_struct Message-ID: References: <20240611182732.360317-1-martin.oliveira@eideticom.com> <20240611182732.360317-2-martin.oliveira@eideticom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240611182732.360317-2-martin.oliveira@eideticom.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Tue, Jun 11, 2024 at 12:27:29PM -0600, Martin Oliveira wrote: > + if (vma->vm_ops->page_mkwrite) > + goto out_put; > + I'd probably make this a WARN_ON so that driver authors trying to add a page_mkwrite in the vm_ops passed to kernfs get a big fat warning instead of spending a couple hours trying to track down what is going wrong :)