mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Raju Lakkaraju <Raju.Lakkaraju@microchip.com>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Raju Lakkaraju <Raju.Lakkaraju@microchip.com>,
	<netdev@vger.kernel.org>, <davem@davemloft.net>,
	<kuba@kernel.org>, <linux-kernel@vger.kernel.org>,
	<bryan.whitehead@microchip.com>, <andrew@lunn.ch>,
	<sbauer@blackbox.su>, <hmehrtens@maxlinear.com>,
	<lxu@maxlinear.com>, <hkallweit1@gmail.com>,
	<edumazet@google.com>, <pabeni@redhat.com>,
	<wojciech.drewek@intel.com>, <UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH net V4 1/3] net: lan743x: disable WOL upon resume to restore full data path operation
Date: Fri, 14 Jun 2024 10:00:58 +0530	[thread overview]
Message-ID: <ZmvHgg5SDYlrO9yB@HYD-DK-UNGSW21.microchip.com> (raw)
In-Reply-To: <ZmqjYEs0G9pGQTog@shell.armlinux.org.uk>

Hi Russell King,

The 06/13/2024 08:44, Russell King (Oracle) wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Wed, Jun 12, 2024 at 10:55:37PM +0530, Raju Lakkaraju wrote:
> > @@ -3728,6 +3729,30 @@ static int lan743x_pm_resume(struct device *dev)
> >               return ret;
> >       }
> >
> > +     ret = lan743x_csr_read(adapter, MAC_WK_SRC);
> > +     netif_info(adapter, drv, adapter->netdev,
> > +                "Wakeup source : 0x%08X\n", ret);
> 
> Does this need to be printed at info level, or is it a debug message?

Print at info level helps the tester/sqa team to identify the root cause of
the wake and confirm the test cases.
In general, tester does not enable debug level messages for testing.

Still, if we need to change from info to debug, i can change.
Please let me know.

> 
> Thanks.
> 
> --
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

-- 
Thanks,                                                                         
Raju

  reply	other threads:[~2024-06-14  4:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-12 17:25 [PATCH net V4 0/3] net: lan743x: Fixes for multiple WOL related issues Raju Lakkaraju
2024-06-12 17:25 ` [PATCH net V4 1/3] net: lan743x: disable WOL upon resume to restore full data path operation Raju Lakkaraju
2024-06-13  7:44   ` Russell King (Oracle)
2024-06-14  4:30     ` Raju Lakkaraju [this message]
2024-06-14 14:17       ` Andrew Lunn
2024-06-14 17:09         ` Raju Lakkaraju
2024-06-12 17:25 ` [PATCH net V4 2/3] net: lan743x: Support WOL at both the PHY and MAC appropriately Raju Lakkaraju
2024-06-13  7:15   ` Horatiu Vultur
2024-06-14  4:26     ` Raju Lakkaraju
2024-06-12 17:25 ` [PATCH net V4 3/3] net: phy: mxl-gpy: Remove interrupt mask clearing from config_init Raju Lakkaraju

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZmvHgg5SDYlrO9yB@HYD-DK-UNGSW21.microchip.com \
    --to=raju.lakkaraju@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=bryan.whitehead@microchip.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=hmehrtens@maxlinear.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=lxu@maxlinear.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sbauer@blackbox.su \
    --cc=wojciech.drewek@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®