From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 833894F605; Wed, 19 Jun 2024 03:07:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718766475; cv=none; b=ASl6I5otEYFjPfKthL7aIyKvFeaoUr2fuOhn8kXBT27NXyKbIK0wFOl3CJ1x15OhX74rxF64fq3+mjvQwUOhOQx+0gUHdcB1Pejlr5RaWlAYgUkZ264HOMzU6yMiWqYBxc05Yss1RZdLdAHEBw0rSvSWlbJSFyyV+aKQs2RCjT4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718766475; c=relaxed/simple; bh=FYTj5zAq9+raq/s0q+bM7+Uld8MuTvLyhTG8RSdv2PA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QWCivtNPiwAR18gSvISBK+ZHNlLEkeGgMitu3xrHAzR4RpuSHefp8HPUivB/vsXzPl4q3S1LwX/qBtWX7rWPcRgBPCypIfsnZmAliUZZNmt7qMA5QD+oVZkCV0Wtpe7kxDlDoZisVJoVb0zqUvuec2VmRb4i8iWhzDZp6uqpAp4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lt+p6Nqg; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lt+p6Nqg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 61FD7C4AF1D; Wed, 19 Jun 2024 03:07:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718766475; bh=FYTj5zAq9+raq/s0q+bM7+Uld8MuTvLyhTG8RSdv2PA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lt+p6Nqg0wRheAVUdY7iQukaWVdfx/VCEM6X1CPHdseJIL6tVNGhiGxDPMZfKM+/+ vUINKaGFCruohgSklELCmTrIqaNXKwb4QM9d3yhyowi93fGNy1CEzjD7ETpOJXGXdZ BlWDG3oGBxuWeHskiOmczMl4WFjZI5/fZhpdLWYPQ5EuwjKKo2QV/C3u9wPg1RfS3M E3bKRMP5+20Ewu2Xg2GQ3baqz1molTMPilfuLi4knOfYmyQZb1YtpLy5+zpUU9VpCV 9gTwmm0EvnldnfQDZBa45njEIxUmlz/5Pu76IMoG2m2aZ1c0ZMrn19CZrpWCe8k+JS DPK41moYiHY/g== Date: Wed, 19 Jun 2024 03:07:50 +0000 From: Tzung-Bi Shih To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Benson Leung , Guenter Roeck , Sebastian Reichel , Thomas =?iso-8859-1?Q?Wei=DFschuh?= , "Rafael J. Wysocki" , Len Brown , Robert Moore , chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Mario Limonciello , Dustin Howett , Stephen Horvath , Rajas Paranjpe , linux-acpi@vger.kernel.org, acpica-devel@lists.linux.dev, Matt Hartley Subject: Re: [PATCH v4 3/5] platform/chrome: cros_ec_proto: Introduce cros_ec_get_cmd_versions() Message-ID: References: <20240616-cros_ec-charge-control-v4-0-74d649a9117d@weissschuh.net> <20240616-cros_ec-charge-control-v4-3-74d649a9117d@weissschuh.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240616-cros_ec-charge-control-v4-3-74d649a9117d@weissschuh.net> On Sun, Jun 16, 2024 at 09:03:31PM +0200, Thomas Weißschuh wrote: > Retrieving the supported versions of a command is a fairly common > operation. Provide a helper for it. > > If the command is not supported at all the EC returns > -EINVAL/EC_RES_INVALID_PARAMS. > > This error is translated into an empty version mask as that is easier to > handle for callers and they don't need to know about the error details. > > Signed-off-by: Thomas Weißschuh In case of the series wouldn't go through chrome-platform tree: Acked-by: Tzung-Bi Shih