From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from e2i411.smtp2go.com (e2i411.smtp2go.com [103.2.141.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 812CC13D265 for ; Wed, 19 Jun 2024 11:24:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.2.141.155 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718796273; cv=none; b=aJtwMhc7o8WbmtwDoiqa7SwuimdMUTb3MbHFCNcyg3mUFmwMD5v2u30Dvu0N9Y3LJuMyUePv85d7leQKxmWUYvYqms/R9h2gp3jgndkLx00t/cSZWf08MPBq82N6zzAwZiLeOyH+/T4QQtSyCMDWdQ6GBtzeQRCmH+bF2blmUBc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718796273; c=relaxed/simple; bh=NAutyFxSP4VjKXvLicjq/fyIJbqML+ZifForgpCt1b8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=orFNSrt0LtBd1c2gkb32J+HAJb9/As5gc2U5ZpmX41ztT0VGO9ZmKYM51Ag6Xk37waflwyB6Fhe4tE058ZXtVKP4dwtn8AIvMnxz3J/u8NnkN4ozVZg3nvdYRCeMuZInpZZ7S5wj3gARhG7MFkZSPY32XluVsOoa/0TiT65zRSw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fjasle.eu; spf=pass smtp.mailfrom=em1174286.fjasle.eu; dkim=fail (0-bit key) header.d=smtpservice.net header.i=@smtpservice.net header.b=c7Q9QLop reason="unknown key version"; dkim=pass (2048-bit key) header.d=fjasle.eu header.i=@fjasle.eu header.b=VO7WaQDi; dkim=pass (1024-bit key) header.d=fjasle.eu header.i=@fjasle.eu header.b=ZZEmhqtw; arc=none smtp.client-ip=103.2.141.155 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fjasle.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=em1174286.fjasle.eu Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="unknown key version" (0-bit key) header.d=smtpservice.net header.i=@smtpservice.net header.b="c7Q9QLop"; dkim=pass (2048-bit key) header.d=fjasle.eu header.i=@fjasle.eu header.b="VO7WaQDi"; dkim=pass (1024-bit key) header.d=fjasle.eu header.i=@fjasle.eu header.b="ZZEmhqtw" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=smtpservice.net; s=mp6320.a1-4.dyn; x=1718797161; h=Feedback-ID: X-Smtpcorp-Track:Message-ID:Subject:To:From:Date:Reply-To:Sender: List-Unsubscribe:List-Unsubscribe-Post; bh=yP8g0Jw2Gy5q84RTF1sYxILlGkYZB2hJ+cHDUm8IPUE=; b=c7Q9QLop80EMjgS7HDMJ3BrseU ndnWuDvn9Sjr/3jdgjsRNX8PQ/xc9X1RB3giFThAvsDhsCDxQPn8Wq0j373fl8JrYPLltFaE3yxbR Wp1/MfwIha0S+/DFHTohZvOErZK0yq7hacbaWd8bj1JZOVd/YqhzSSqBYLDhk2Ksv8B9bcQLoZL0y xF9z00S2dW/qL97eP7bNWjEDmD917bW20ZI0jFp4I+RKtDNG4w3IrUwIvrk1uw86FbpGYzOLQgadD F8gbI9x7iy5j51jwjfSmomnBJ4eJ734B7zB7f8i6GePdWQQ6ZXHidQXIX6IaQ+infDrI8a5Sb/+LY 9mTUStrA==; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fjasle.eu; i=@fjasle.eu; q=dns/txt; s=s1174286; t=1718796261; h=from : subject : to : message-id : date; bh=yP8g0Jw2Gy5q84RTF1sYxILlGkYZB2hJ+cHDUm8IPUE=; b=VO7WaQDi50K25IxobvfCv/Cam2Zquz/b4d5nrqPsZeGG5U0NDjEuwF8q9edhosVOTBaMU zRkjj/bc0Di2GnHXkE8ss6fU+5gIdGmVr8qF3Lj5/V63vlYTMcyXhN0sww7IEMLCgePjUkm IjkwPSfBF+8tKoVJHbOEyF288QJrGlJQ8EVQEJrlL/QCOlpI8yFtQ79QGPF6svQlvKYQgXe OZZEWbitEe3y8po3MfYzTU+AP12DZ3gqh+IvQ8ICZKHE6LqBeJ0a4NVOXzwNvaLhJUmJ9xk 8btjS82/W2BImqYsSd7yN8Y8iayRXdH2SPk66IBE7GzYrvwn4IE3TYrtajPg== Received: from [10.139.162.187] (helo=SmtpCorp) by smtpcorp.com with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2-S2G) (envelope-from ) id 1sJtOa-TRk6ya-D7; Wed, 19 Jun 2024 11:22:33 +0000 Received: from [10.85.249.164] (helo=leknes.fjasle.eu) by smtpcorp.com with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.97.1-S2G) (envelope-from ) id 1sJtOb-4o5NDgrtWcB-kWHs; Wed, 19 Jun 2024 11:22:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fjasle.eu; s=mail; t=1718796149; bh=NAutyFxSP4VjKXvLicjq/fyIJbqML+ZifForgpCt1b8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZZEmhqtwqS2x5F5aTxHhkZ1xnS+1M6nDigDUWHMrfdZt9gqvWLN9Wi9VdXSBIJkRF Qu5CXSdmsmFde40Tmouy0mogaiiWWdoirTAkdhRE3zesg8nhzWwhiZ/FsTYf95GWQ2 Gagqq2ObQW1vnQnDZ5s5AiEu7C3caxSlAbugzq8E= Received: by leknes.fjasle.eu (Postfix, from userid 1000) id 995503E76F; Wed, 19 Jun 2024 13:22:28 +0200 (CEST) Date: Wed, 19 Jun 2024 13:22:28 +0200 From: Nicolas Schier To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, Peter Zijlstra , Josh Poimboeuf , linux-kernel@vger.kernel.org, Sami Tolvanen , Brian Norris , Nathan Chancellor Subject: Re: [PATCH] Makefile: add comment to discourage tools/* addition for kernel builds Message-ID: References: <20240619062145.3967720-1-masahiroy@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240619062145.3967720-1-masahiroy@kernel.org> X-Smtpcorp-Track: XM4iittdWoiQ.PibnpsphkpdX.k8-UUwSVN-6 Feedback-ID: 1174286m:1174286a9YXZ7r:1174286sOfuMnkZRi X-Report-Abuse: Please forward a copy of this message, including all headers, to On Wed, Jun 19, 2024 at 03:21:42PM +0900 Masahiro Yamada wrote: > Kbuild provides scripts/Makefile.host to build host programs used for > building the kernel. Unfortunately, there are two exceptions that opt > out of Kbuild. The build system under tools/ is a cheesy replica, and > is always a disaster. I was recently poked about a problem in the tools > build issue, which I do not maintain (and nobody maintains). [1] > > Without a comment, somebody might believe this is the right location > because that is where objtool lives, even when a more robust Kbuild > syntax satisfies their needs. [2] > > [1]: https://lore.kernel.org/linux-kbuild/ZnIYWBgrJ-IJtqK8@google.com/T/#m8ece130dd0e23c6f2395ed89070161948dee8457 > [2]: https://lore.kernel.org/all/20240618200501.GA1611012@google.com/ > > Signed-off-by: Masahiro Yamada > --- > > Makefile | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Makefile b/Makefile > index 471f2df86422..ba070596ad4e 100644 > --- a/Makefile > +++ b/Makefile > @@ -1331,6 +1331,11 @@ prepare: tools/bpf/resolve_btfids > endif > endif > > +# README > +# The tools build system is not a part of Kbuild. Before adding yet another > +# tools/* here, please consider if the standard "hostprogs" syntax satisfies > +# your needs. > + Perhaps add a "See Documentation/kbuild/makefiles.rst for details." ? I do understand the need for clarification. Acked-by: Nicolas Schier