From: JieGan <quic_jiegan@quicinc.com>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Konrad Dybcio <konradybcio@gmail.com>,
Mike Leach <mike.leach@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jinlong Mao <quic_jinlmao@quicinc.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<coresight@lists.linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
Tingwei Zhang <quic_tingweiz@quicinc.com>,
Yuanfang Zhang <quic_yuanfang@quicinc.com>,
"Tao Zhang" <quic_taozha@quicinc.com>,
Trilok Soni <quic_tsoni@quicinc.com>,
"Song Chai" <quic_songchai@quicinc.com>,
<linux-arm-msm@vger.kernel.org>, <andersson@kernel.org>,
<quic_yijiyang@quicinc.com>, <quic_yuanjiey@quicinc.com>,
<quic_liuxin@quicinc.com>, <quic_yanzl@quicinc.com>,
<quic_xinlon@quicinc.com>, <quic_xueqnie@quicinc.com>,
<quic_sijiwu@quicinc.com>
Subject: Re: [PATCH] Coresight: Set correct cs_mode for TPDM to fix disable issue
Date: Wed, 26 Jun 2024 09:24:43 +0800 [thread overview]
Message-ID: <Zntt23e+YhHboh30@jiegan-gv.ap.qualcomm.com> (raw)
In-Reply-To: <2e78b732-aed7-4de5-b5ac-0da5b78af342@arm.com>
On Tue, Jun 25, 2024 at 01:24:11PM +0100, Suzuki K Poulose wrote:
> On 25/06/2024 03:12, Jie Gan wrote:
> > The coresight_disable_source_sysfs function should verify the
> > mode of the coresight device before disabling the source.
> > However, the mode for the TPDM device is always set to
> > CS_MODE_DISABLED, resulting in the check consistently failing.
> > As a result, TPDM cannot be properly disabled.
> >
> > To fix the issue:
> > Configure CS_MODE_SYSFS/CS_MODE_PERF during the enablement of TPDM.
> > Configure CS_MODE_DISABLED during the disablement of TPDM.
> >
> > Fixes: 1f5149c7751c("coresight: Move all sysfs code to sysfs file")
>
> That looks like the wrong commit. This was a problem since the original
> TPDM driver. I would say :
>
> Fixes: b3c71626a933 ("Coresight: Add coresight TPDM source driver")
I will correct the Fixes tag and re-send the patch.
>
> > Signed-off-by: Jie Gan <quic_jiegan@quicinc.com>
>
> Otherwise, the patch looks good to me.
>
> Please could you also fixup "dummy" source driver in a separate patch.
Sure.
>
> Suzuki
>
Thanks,
Jie
prev parent reply other threads:[~2024-06-26 1:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 2:12 Jie Gan
2024-06-25 12:24 ` Suzuki K Poulose
2024-06-26 1:24 ` JieGan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zntt23e+YhHboh30@jiegan-gv.ap.qualcomm.com \
--to=quic_jiegan@quicinc.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=andersson@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=konradybcio@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=quic_jinlmao@quicinc.com \
--cc=quic_liuxin@quicinc.com \
--cc=quic_sijiwu@quicinc.com \
--cc=quic_songchai@quicinc.com \
--cc=quic_taozha@quicinc.com \
--cc=quic_tingweiz@quicinc.com \
--cc=quic_tsoni@quicinc.com \
--cc=quic_xinlon@quicinc.com \
--cc=quic_xueqnie@quicinc.com \
--cc=quic_yanzl@quicinc.com \
--cc=quic_yijiyang@quicinc.com \
--cc=quic_yuanfang@quicinc.com \
--cc=quic_yuanjiey@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®