From: Herbert Xu <herbert@gondor.apana.org.au>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: Horia Geanta <horia.geanta@nxp.com>,
Pankaj Gupta <pankaj.gupta@nxp.com>,
Gaurav Jain <gaurav.jain@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] crypto: caam - enable hash api only on ARM platforms per default
Date: Wed, 10 Jul 2024 06:11:30 +1000 [thread overview]
Message-ID: <Zo2ZcqP5zSLB0mf+@gondor.apana.org.au> (raw)
In-Reply-To: <20240709085454.you3b3ueb3xbtrv6@pengutronix.de>
On Tue, Jul 09, 2024 at 10:54:54AM +0200, Marco Felsch wrote:
>
> We had an patch exactly doing this but depending on the SoC the default
> prio may valid since the CAAM is used on ARMv7 and ARMv8 NXP SoCs. To
> not cause any regression we went this way.
I don't understand. Why not just set the priority depending on
IS_ENABLED(CONFIG_ARM)? That way it's strictly better than the
Kconfig patch:
1) If the driver is indeed slower then you'd have achieved the same
result of preferring the non-driver algorithm.
2) If the driver ends up being faster then at least the admin can
adjust the priorities.
Or perhaps your Kconfig option should set the priority.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2024-07-09 20:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 15:57 Marco Felsch
2024-07-05 9:39 ` Horia Geanta
2024-07-05 11:01 ` Herbert Xu
2024-07-09 8:54 ` Marco Felsch
2024-07-09 20:11 ` Herbert Xu [this message]
2024-07-10 6:51 ` Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zo2ZcqP5zSLB0mf+@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=gaurav.jain@nxp.com \
--cc=horia.geanta@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=pankaj.gupta@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®