From: Pavel Machek <pavel@denx.de>
To: Greg KH <greg@kroah.com>
Cc: Pavel Machek <pavel@denx.de>, Sasha Levin <sashal@kernel.org>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Dmitry Antipov <dmantipov@yandex.ru>,
syzbot+253cd2d2491df77c93ac@syzkaller.appspotmail.com,
Johannes Berg <johannes.berg@intel.com>,
johannes@sipsolutions.net, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 4.19] wifi: cfg80211: wext: add extra SIOCSIWSCAN data check
Date: Wed, 10 Jul 2024 14:06:00 +0200 [thread overview]
Message-ID: <Zo55KEC5MmfeXJxq@duo.ucw.cz> (raw)
In-Reply-To: <2024071033-geologic-emerald-f6a2@gregkh>
[-- Attachment #1: Type: text/plain, Size: 947 bytes --]
On Wed 2024-07-10 12:24:55, Greg KH wrote:
> On Wed, Jul 10, 2024 at 12:04:15PM +0200, Pavel Machek wrote:
> > Hi!
> >
> > > [ Upstream commit 6ef09cdc5ba0f93826c09d810c141a8d103a80fc ]
> > >
> > > In 'cfg80211_wext_siwscan()', add extra check whether number of
> > > channels passed via 'ioctl(sock, SIOCSIWSCAN, ...)' doesn't exceed
> > > IW_MAX_FREQUENCIES and reject invalid request with -EINVAL otherwise.
> >
> > This results in very confusing code in 4.19 at least. It should goto
> > out for consistency, exploting kfree(NULL) to be nop. Ok, not sure we
> > care...
>
> kfree(NULL) is always supposed to be a nop, we have relied on that for
> decades, that's not an issue anywhere.
Take a look at the code, especially after this patch is applied.
BR,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
prev parent reply other threads:[~2024-07-10 12:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 0:15 Sasha Levin
2024-07-10 10:04 ` Pavel Machek
2024-07-10 10:24 ` Greg KH
2024-07-10 12:06 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zo55KEC5MmfeXJxq@duo.ucw.cz \
--to=pavel@denx.de \
--cc=davem@davemloft.net \
--cc=dmantipov@yandex.ru \
--cc=edumazet@google.com \
--cc=greg@kroah.com \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=syzbot+253cd2d2491df77c93ac@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®