From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [185.142.180.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 468EB12CDB0; Mon, 1 Jul 2024 11:21:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.142.180.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719832887; cv=none; b=m1CKUhH+e/7RULwyHl/NUUltvoVm6o42jBxPsVlpGe10jcceWVSgzpz2cYYH1qEJL9w0LAslvEvj54zyTngOM9PY6+Rgly9Ct2XsfhYpx24G4xjLoNcbXevw5PmcrJYzxmLSWlyylnuy3JsysavbwdUu77e/GPamapCYT+vB71c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719832887; c=relaxed/simple; bh=JOzJZ9bsQdjN0b6Bn+BCyZRD0ZGpRjDY8984P99UG+A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=o+A9IrwyBl8Uezzg/s1XCP7OYKlowmz5z6IRcgERJilHAhY31Bt9uatCaYfIST51/D2J+4onW07IivsR/YFEHVYVCw4WwcN17/H2HZe+RhCT4sLSaEbPGOJAO4ceWrKPo7r5AmqQNTrUVoQf18A5C4NGgrwW+9fUJt3ihVy+NtE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org; spf=pass smtp.mailfrom=makrotopia.org; arc=none smtp.client-ip=185.142.180.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=makrotopia.org Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.97.1) (envelope-from ) id 1sOF5m-000000006YZ-0Ekn; Mon, 01 Jul 2024 11:21:06 +0000 Date: Mon, 1 Jul 2024 12:20:59 +0100 From: Daniel Golle To: Sky Huang Cc: Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Qingfang Deng , Matthias Brugger , AngeloGioacchino Del Regno , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Steven Liu Subject: Re: [PATCH net-next v10 13/13] net: phy: mediatek: Remove unnecessary outer parens of "supported_triggers" var Message-ID: References: <20240701105417.19941-1-SkyLake.Huang@mediatek.com> <20240701105417.19941-14-SkyLake.Huang@mediatek.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240701105417.19941-14-SkyLake.Huang@mediatek.com> On Mon, Jul 01, 2024 at 06:54:17PM +0800, Sky Huang wrote: > From: "SkyLake.Huang" > > This patch removes unnecessary outer parens of "supported_triggers" vars > in mtk-ge.c & mtk-ge-soc.c to improve readability. > > Signed-off-by: SkyLake.Huang > --- > diff --git a/drivers/net/phy/mediatek/mtk-ge.c b/drivers/net/phy/mediatek/mtk-ge.c > index 90f3990..050a4f7 100644 > --- a/drivers/net/phy/mediatek/mtk-ge.c > +++ b/drivers/net/phy/mediatek/mtk-ge.c > @@ -152,14 +152,14 @@ static int mt753x_phy_led_brightness_set(struct phy_device *phydev, > } > > static const unsigned long supported_triggers = > - (BIT(TRIGGER_NETDEV_FULL_DUPLEX) | > - BIT(TRIGGER_NETDEV_HALF_DUPLEX) | > - BIT(TRIGGER_NETDEV_LINK) | > - BIT(TRIGGER_NETDEV_LINK_10) | > - BIT(TRIGGER_NETDEV_LINK_100) | > - BIT(TRIGGER_NETDEV_LINK_1000) | > - BIT(TRIGGER_NETDEV_RX) | > - BIT(TRIGGER_NETDEV_TX)); > + BIT(TRIGGER_NETDEV_FULL_DUPLEX) | > + BIT(TRIGGER_NETDEV_HALF_DUPLEX) | > + BIT(TRIGGER_NETDEV_LINK) | > + BIT(TRIGGER_NETDEV_LINK_10) | > + BIT(TRIGGER_NETDEV_LINK_100) | > + BIT(TRIGGER_NETDEV_LINK_1000) | > + BIT(TRIGGER_NETDEV_RX) | > + BIT(TRIGGER_NETDEV_TX); Those lines are added within the same series by patch 06/13 ("net: phy: mediatek: Hook LED helper functions in mtk-ge.c"). I get and like the idea of doing things one by one, but in this case instead of editing what you have just added, better move the commit removing the unnecessary parentheses somewhere before copying them to the mtk-ge.c driver in patch 6/13. All the rest looks good to me now.