mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Mikulas Patocka <mpatocka@redhat.com>,
	Lai Jiangshan <jiangshanlai@gmail.com>,
	Waiman Long <longman@redhat.com>,
	Mike Snitzer <snitzer@kernel.org>,
	Laurence Oberman <loberman@redhat.com>,
	Jonathan Brassow <jbrassow@redhat.com>,
	Ming Lei <minlei@redhat.com>, Ondrej Kozina <okozina@redhat.com>,
	Milan Broz <gmazyland@gmail.com>,
	linux-kernel@vger.kernel.org, dm-devel@lists.linux.dev,
	users@lists.libvirt.org
Subject: Re: dm-crypt performance regression due to workqueue changes
Date: Mon, 1 Jul 2024 07:25:27 -1000	[thread overview]
Message-ID: <ZoLmh5L7WrBqtn79@slm.duckdns.org> (raw)
In-Reply-To: <ZoK0kwzis1iWVyLr@redhat.com>

Hello,

On Mon, Jul 01, 2024 at 02:52:19PM +0100, Daniel P. Berrangé wrote:
...
> None the less, I'd suggest that virt-manager should be a explicitly
> asking for sockets=1,cores=N, as that has broader guest OS compatibility.

+1. Multiple sockets is pretty uncommon and often comes with significant
performance implications - e.g. if VM is also splitting memory into N nodes,
that can lead to significant higher overhead during reclaim due to node
imbalances and premature OOMs. If the reported topology is not real, it
makes a lot more sense to keep it basic.

Thanks.

-- 
tejun

      reply	other threads:[~2024-07-01 17:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-29 18:15 Mikulas Patocka
2024-06-29 18:29 ` Waiman Long
2024-06-30  9:49   ` Mikulas Patocka
2024-06-30 14:35     ` Waiman Long
2024-06-30 17:13 ` Tejun Heo
2024-06-30 18:49   ` Mikulas Patocka
2024-07-01 12:48     ` Michal Prívozník
2024-07-01 13:25       ` Daniel P. Berrangé
2024-07-01 13:40         ` Mikulas Patocka
2024-07-01 13:08     ` Daniel P. Berrangé
2024-07-01 13:42       ` Mikulas Patocka
2024-07-01 13:52         ` Daniel P. Berrangé
2024-07-01 17:25           ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZoLmh5L7WrBqtn79@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=berrange@redhat.com \
    --cc=dm-devel@lists.linux.dev \
    --cc=gmazyland@gmail.com \
    --cc=jbrassow@redhat.com \
    --cc=jiangshanlai@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loberman@redhat.com \
    --cc=longman@redhat.com \
    --cc=minlei@redhat.com \
    --cc=mpatocka@redhat.com \
    --cc=okozina@redhat.com \
    --cc=snitzer@kernel.org \
    --cc=users@lists.libvirt.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®