mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Aboorva Devarajan <aboorvad@linux.ibm.com>
Cc: void@manifault.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH sched_ext/for-6.11] sched_ext: Documentation: Remove mentions of scx_bpf_switch_all
Date: Mon, 1 Jul 2024 07:53:30 -1000	[thread overview]
Message-ID: <ZoLtGmBw6kcNtmts@slm.duckdns.org> (raw)
In-Reply-To: <20240701123022.68700-1-aboorvad@linux.ibm.com>

Hello,

On Mon, Jul 01, 2024 at 06:00:22PM +0530, Aboorva Devarajan wrote:
...
> +sched_ext is used only when the BPF scheduler is loaded and running. To use
> +sched_ext, a task can invoke ``sched_setscheduler`` with the ``SCHED_EXT``
> +policy constant.

I wonder whether the last sentence is a bit confusing given that tasks can
be on SCX without setting SCHED_EXT.

> +When the BPF scheduler is not loaded, tasks with the ``SCHED_EXT`` policy are
> +treated as ``SCHED_NORMAL`` and scheduled by CFS. ``SCHED_NORMAL`` tasks
> +continue to be scheduled by CFS.
> +
> +When the BPF scheduler is loaded, all tasks with the ``SCHED_EXT`` policy are
> +switched to sched_ext. By default, if the ``struct ops->flag`` is not set to
> +``SCX_OPS_SWITCH_PARTIAL``, ``SCHED_EXT``, ``SCHED_NORMAL``, and lower class
> +tasks are scheduled by sched_ext. In this case, all ``SCHED_NORMAL``,
> +``SCHED_BATCH``, ``SCHED_IDLE``, and ``SCHED_EXT`` tasks are scheduled by
> +sched_ext.

How about something like:

When the BPF scheduler is loaded and ``SCX_OPS_SWITCH_PARTIAL`` is not set
in ops->flags, all ``SCHED_NORMAL``, ``SCHED_BATCH``, ``SCHED_IDLE``, and
``SCHED_EXT`` tasks are scheduled by sched_ext.

> +However, if the ``struct ops->flag`` is set to``SCX_OPS_SWITCH_PARTIAL``,
> +only tasks with the policy set to ``SCHED_EXT`` are scheduled by sched_ext.

And update this paragraph in a similar fashion?

Thanks.

-- 
tejun

  reply	other threads:[~2024-07-01 17:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-01 12:30 Aboorva Devarajan
2024-07-01 17:53 ` Tejun Heo [this message]
2024-07-02  8:40   ` Aboorva Devarajan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZoLtGmBw6kcNtmts@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=aboorvad@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=void@manifault.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®