From: Christoph Hellwig <hch@infradead.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: dm-devel@lists.linux.dev, Alasdair Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@kernel.org>,
Mikulas Patocka <mpatocka@redhat.com>,
linux-kernel@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>,
Sami Tolvanen <samitolvanen@google.com>,
Bart Van Assche <bvanassche@acm.org>
Subject: Re: [PATCH 4/7] dm-verity: provide dma_alignment limit in io_hints
Date: Tue, 2 Jul 2024 00:16:51 -0700 [thread overview]
Message-ID: <ZoOpYxX-7_HD9zXH@infradead.org> (raw)
In-Reply-To: <20240702064835.120541-5-ebiggers@kernel.org>
> +
> + limits->dma_alignment = limits->logical_block_size - 1;
Please add a comment here to explain the limit based on the commit log
text.
next prev parent reply other threads:[~2024-07-02 7:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 6:48 [PATCH 0/7] dm-verity cleanups and optimizations Eric Biggers
2024-07-02 6:48 ` [PATCH 1/7] dm-verity: move hash algorithm setup into its own function Eric Biggers
2024-07-02 6:48 ` [PATCH 2/7] dm-verity: move data hash mismatch handling " Eric Biggers
2024-07-02 6:48 ` [PATCH 3/7] dm-verity: make real_digest and want_digest fixed-length Eric Biggers
2024-07-02 6:48 ` [PATCH 4/7] dm-verity: provide dma_alignment limit in io_hints Eric Biggers
2024-07-02 7:16 ` Christoph Hellwig [this message]
2024-07-02 6:48 ` [PATCH 5/7] dm-verity: always "map" the data blocks Eric Biggers
2024-07-02 6:48 ` [PATCH 6/7] dm-verity: make verity_hash() take dm_verity_io instead of ahash_request Eric Biggers
2024-07-02 6:48 ` [PATCH 7/7] dm-verity: hash blocks with shash import+finup when possible Eric Biggers
2024-07-02 7:41 ` Ard Biesheuvel
2024-07-02 17:16 ` Eric Biggers
2024-07-03 13:17 ` Ard Biesheuvel
2024-07-03 19:15 ` [PATCH 0/7] dm-verity cleanups and optimizations Eric Biggers
2024-07-04 15:05 ` Mikulas Patocka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZoOpYxX-7_HD9zXH@infradead.org \
--to=hch@infradead.org \
--cc=agk@redhat.com \
--cc=ardb@kernel.org \
--cc=bvanassche@acm.org \
--cc=dm-devel@lists.linux.dev \
--cc=ebiggers@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=samitolvanen@google.com \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®