Re: [PATCH] [RFC] mwifiex: Fix NULL pointer deref

[Francesco Dolcini <francesco@dolcini.it>]

On Tue, Jul 02, 2024 at 03:32:16PM +0200, Sascha Hauer wrote:
> On Mon, Jun 24, 2024 at 06:20:14PM +0200, Francesco Dolcini wrote:
> > On Fri, Jun 21, 2024 at 11:07:27AM +0200, Sascha Hauer wrote:

...

> > > 
> > > From 3357963821294ff7de26259a154a1cb5bab760cb Mon Sep 17 00:00:00 2001
> > > From: Sascha Hauer <s.hauer@pengutronix.de>
> > > Date: Tue, 18 Jun 2024 12:20:20 +0200
> > > Subject: [PATCH] mwifiex: Do not return unused priv in
> > >  mwifiex_get_priv_by_id()
> > > 
> > > mwifiex_get_priv_by_id() returns the priv pointer corresponding to the
> > > bss_num and bss_type, but without checking if the priv is actually
> > > currently in use.
> > > Unused priv pointers do not have a wiphy attached to them which can lead
> > > to NULL pointer dereferences further down the callstack.
> > > Fix this by returning only used priv pointers which have priv->bss_mode
> > > set to something else than NL80211_IFTYPE_UNSPECIFIED.
> > > 
> > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>

I guess you should send it as a proper patch?


...

> > I am just wondering if this might have anything to do with
> > commit a17b9f590f6e ("wifi: mwifiex: Fix interface type change"), maybe you have already looked into it?
> 
> It looks somehow related. I just gave it a try and it at least doesn't
> fix my issue.

thanks for trying it out.


Francesco