mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Hongyan Xia <hongyan.xia2@arm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] sched/uclamp: Delegate uclamp to each sched_class
Date: Wed, 3 Jul 2024 08:13:30 -1000	[thread overview]
Message-ID: <ZoWUyrYwVDqSMBam@slm.duckdns.org> (raw)
In-Reply-To: <45e58e2fe1f72d6c095c8824c7da696edfd80bd7.1719999165.git.hongyan.xia2@arm.com>

On Wed, Jul 03, 2024 at 11:07:47AM +0100, Hongyan Xia wrote:
> uclamp-related operations are written in core.c in a way that may
> suggest it is a global thing regardless of sched_class, but we end up
> checking sched_class->uclamp_enabled, so in reality it is sched_class
> specific anyway.
> 
> Remove sched_class->uclamp_enabled and simply delegate uclamp to
> sched_class->{enqueue,dequeue}_task(). This also removes extra
> uclamp_enabled checks in uclamp_rq_{inc,dec}().
> 
> No functional changes for fair and RT.
> 
> Signed-off-by: Hongyan Xia <hongyan.xia2@arm.com>

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

-- 
tejun

  reply	other threads:[~2024-07-03 18:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-03 10:07 [PATCH 0/2] Move " Hongyan Xia
2024-07-03 10:07 ` [PATCH 1/2] sched/uclamp: Delegate " Hongyan Xia
2024-07-03 18:13   ` Tejun Heo [this message]
2024-07-03 10:07 ` [PATCH 2/2] sched/ext: Add BPF functions for uclamp inc and dec Hongyan Xia
2024-07-03 18:15   ` Tejun Heo
2024-07-03 19:49     ` Hongyan Xia
2024-07-03 18:13 ` [PATCH 0/2] Move uclamp to each sched_class Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZoWUyrYwVDqSMBam@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=hongyan.xia2@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®