From: Petr Mladek <pmladek@suse.com>
To: John Ogness <john.ogness@linutronix.de>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, Juri Lelli <juri.lelli@redhat.com>
Subject: Re: [PATCH printk 1/1] printk: nbcon: do not require migration disabled for nbcon_get_cpu_emergency_nesting()
Date: Mon, 22 Jul 2024 15:58:41 +0200 [thread overview]
Message-ID: <Zp5lcOihG4d6SNjt@pathway.suse.cz> (raw)
In-Reply-To: <20240719134818.3311665-2-john.ogness@linutronix.de>
On Fri 2024-07-19 15:54:18, John Ogness wrote:
> Since entering emergency state disables preemption, there is no
> need for nbcon_get_cpu_emergency_nesting() to explicitly require
> migration disasbled. Either the current CPU is in emergency state
> (and thus preemption is disabled and the nesting level is not
> zero) or the current CPU is not in emergency state and the nesting
> level must by definition be zero, even when migration is enabled
> and the current CPU could change. The current CPU could never
> change to a CPU that is in emergency state.
>
> Reported-by: Juri Lelli <juri.lelli@redhat.com>
> Closes: https://lore.kernel.org/aqkcpca4vgadxc3yzcu74xwq3grslj5m43f3eb5fcs23yo2gy4@gcsnqcts5tos
> Fixes: 46a1379208b7 ("printk: nbcon: Implement emergency sections")
> Signed-off-by: John Ogness <john.ogness@linutronix.de>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
next prev parent reply other threads:[~2024-07-22 13:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-19 13:48 [PATCH printk 0/1] alternate fix for nbcon_cpu_emergency_flush() John Ogness
2024-07-19 13:48 ` [PATCH printk 1/1] printk: nbcon: do not require migration disabled for nbcon_get_cpu_emergency_nesting() John Ogness
2024-07-22 13:58 ` Petr Mladek [this message]
2024-07-22 14:47 ` [PATCH printk 0/1] alternate fix for nbcon_cpu_emergency_flush() Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zp5lcOihG4d6SNjt@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=john.ogness@linutronix.de \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®