From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69536440C for ; Fri, 12 Jul 2024 15:25:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720797950; cv=none; b=tgbWmaHfoXRV0P6Yt/r4kA5KW1gjeAtSE251z5DeE5HVaQJkcunO5m7cKuTBtTYvXoO66PnUdDvr2fH6tAddxz9nlyNA/ZpGKLL6IjF/2KXP5k6hlQuF3ggHKuMPzcNxb53cZrvs9L+xUxCpol5TqQo0+0Il/8YLtw2fXPOCDeQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720797950; c=relaxed/simple; bh=3eUESbWw7CZsZFdS41zOQ9g+h/GToJLx+xh933r+pfE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RjosPQ+p7bUYkkeVZ2DAKgeMNUP4diTdNLv4te571tZdUaH1HwrYQxKnY/72kp/WIk+Ro23hH6v0fWjZVtsJBvswF14cf+uGhAcqnQ2ig6vrczhAjiHJ1d8eMqC45rjXPnA/UuKjgpN6XskdesM3OlPDvN5DwJ3TeB4hpgEawVo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sSI9U-00037k-C6; Fri, 12 Jul 2024 17:25:40 +0200 Received: from [2a0a:edc0:2:b01:1d::c5] (helo=pty.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sSI9T-0091pv-Hx; Fri, 12 Jul 2024 17:25:39 +0200 Received: from ore by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1sSI9T-00CLua-1U; Fri, 12 Jul 2024 17:25:39 +0200 Date: Fri, 12 Jul 2024 17:25:39 +0200 From: Oleksij Rempel To: Andrew Lunn Cc: Heiner Kallweit , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next v1 1/1] net: phy: dp83td510: add cable testing support Message-ID: References: <20240708140542.2424824-1-o.rempel@pengutronix.de> <3e1103cf-6023-475d-9532-2e5840ed14f8@lunn.ch> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <3e1103cf-6023-475d-9532-2e5840ed14f8@lunn.ch> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org On Fri, Jul 12, 2024 at 05:20:06PM +0200, Andrew Lunn wrote: > > > > +#define DP83TD510E_TDR_CFG2 0x301 > > > > +#define DP83TD510E_TDR_END_TAP_INDEX_1 GENMASK(14, 8) > > > > +#define DP83TD510E_TDR_END_TAP_INDEX_1_DEF 36 > > > > +#define DP83TD510E_TDR_START_TAP_INDEX_1 GENMASK(6, 0) > > > > +#define DP83TD510E_TDR_START_TAP_INDEX_1_DEF 3 > > > > > > Does this correspond the minimum and maximum distance it will test? > > > Is this 3m to 36m? > > > > No. At least, i can't confirm it with tests. > > > > If I see it correctly, this PHY is using SSTDR instead of usual TDR. > > Instead of pulses it will send modulated transmission with default > > length of 16ms > > > > I tried my best google foo, but was not able to find anything > > understandable about "Start/End tap index for echo coeff sweep for segment 1" > > im context of SSTDR. If anyone know more about this, please tell me :) > > I was just curious. Does not really matter with respect to getting the > patch applied. No problem, I was so nerd sniped that I had to dive deeper into the matter :) -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |