From: Sascha Hauer <s.hauer@pengutronix.de>
To: Kalle Valo <kvalo@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Brian Norris <briannorris@chromium.org>,
Francesco Dolcini <francesco@dolcini.it>,
linux-wireless@vger.kernel.org, David Lin <yu-hao.lin@nxp.com>
Subject: Re: [PATCH] wifi: mwifiex: increase max_num_akm_suites
Date: Tue, 16 Jul 2024 11:10:16 +0200 [thread overview]
Message-ID: <ZpY4-PpxgMOH0wQB@pengutronix.de> (raw)
In-Reply-To: <20240530130156.1651174-1-s.hauer@pengutronix.de>
On Thu, May 30, 2024 at 03:01:56PM +0200, Sascha Hauer wrote:
> The maximum number of AKM suites will be set to two if not specified by
> the driver. Set it to CFG80211_MAX_NUM_AKM_SUITES to let userspace
> specify up to ten AKM suites in the akm_suites array.
>
> Without only the first two AKM suites will be used, further ones are
> ignored.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>
> Current wpa_supplicant/hostapd only put a maximum of two into the
> akm_suites array as well, a patch changing this can be found here:
> http://lists.infradead.org/pipermail/hostap/2024-May/042720.html
This was recently merged: http://lists.infradead.org/pipermail/hostap/2024-July/042802.html
Kalle, given that userspace now would be able to make use of a bigger
AKM suites array, can we merge this patch for the kernel as well?
Sascha
> ---
> drivers/net/wireless/marvell/mwifiex/cfg80211.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> index b909a7665e9cc..908dfe01c30d7 100644
> --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> @@ -4358,6 +4358,8 @@ int mwifiex_register_cfg80211(struct mwifiex_adapter *adapter)
> BIT(NL80211_IFTYPE_P2P_GO) |
> BIT(NL80211_IFTYPE_AP);
>
> + wiphy->max_num_akm_suites = CFG80211_MAX_NUM_AKM_SUITES;
> +
> if (ISSUPP_ADHOC_ENABLED(adapter->fw_cap_info))
> wiphy->interface_modes |= BIT(NL80211_IFTYPE_ADHOC);
>
> --
> 2.39.2
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2024-07-16 9:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-30 13:01 Sascha Hauer
2024-06-06 12:25 ` Kalle Valo
2024-06-10 7:27 ` Sascha Hauer
2024-06-11 13:12 ` Marcel Ziswiler
2024-06-12 13:03 ` s.hauer
2024-06-20 18:05 ` Brian Norris
2024-06-21 8:48 ` Sascha Hauer
2024-06-21 19:16 ` Brian Norris
2024-07-16 9:10 ` Sascha Hauer [this message]
2024-07-30 8:48 ` Kalle Valo
2024-08-04 8:54 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZpY4-PpxgMOH0wQB@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=briannorris@chromium.org \
--cc=francesco@dolcini.it \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=yu-hao.lin@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®