mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Juri Lelli <juri.lelli@redhat.com>
To: Wander Lairson Costa <wander@redhat.com>
Cc: Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
	Valentin Schneider <vschneid@redhat.com>,
	"open list:SCHEDULER" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/2] sched/deadline: fixes and improvements
Date: Thu, 25 Jul 2024 09:29:26 +0200	[thread overview]
Message-ID: <ZqH-1o9pc062F-hG@jlelli-thinkpadt14gen4.remote.csb> (raw)
In-Reply-To: <20240724142253.27145-1-wander@redhat.com>

Hi Wander,

On 24/07/24 11:22, Wander Lairson Costa wrote:
> Hello,
> 
> This patch series addresses specific issues and improvements within
> the scheduler's deadline (DL) class. The patches aim to fix warnings,
> remove redundant checks, and consolidate timer cancellation logic for
> better consistency and code quality.
> 
> Patch 1: Fix warning in migrate_enable for boosted tasks
> 
> Fix a warning caused by unnecessary calls to setup_new_dl_entity for
> boosted tasks during CPU migate_enable calls.
> 
> Patch 2: sched/deadline: Consolidate Timer Cancellation
> 
> Consolidate timer cancellation logic into dedicated functions,
> ensuring consistent behavior and reducing code duplication.
> 
> Changelog
> ---------
> 
> v2:
> * Drop patch to remove the redundant WARN_ON call.
> * Change the "Fixes" tag in the patch 1.
> * Change function names in the patch 2.
> 
> Wander Lairson Costa (2):
>   sched/deadline: Fix warning in migrate_enable for boosted tasks
>   sched/deadline: Consolidate Timer Cancellation
> 
>  kernel/sched/deadline.c | 45 ++++++++++++++++++++++++++---------------
>  1 file changed, 29 insertions(+), 16 deletions(-)

Looks good to me now.

Acked-by: Juri Lelli <juri.lelli@redhat.com>

Thanks!
Juri


  parent reply	other threads:[~2024-07-25  7:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-24 14:22 Wander Lairson Costa
2024-07-24 14:22 ` [PATCH v2 1/2] sched/deadline: Fix warning in migrate_enable for boosted tasks Wander Lairson Costa
2024-12-02 11:14   ` [tip: sched/core] " tip-bot2 for Wander Lairson Costa
2024-07-24 14:22 ` [PATCH v2 2/2] sched/deadline: Consolidate Timer Cancellation Wander Lairson Costa
2024-12-02 11:14   ` [tip: sched/core] " tip-bot2 for Wander Lairson Costa
2024-07-25  7:29 ` Juri Lelli [this message]
2024-08-07 10:59   ` [PATCH v2 0/2] sched/deadline: fixes and improvements Peter Zijlstra
2024-08-07 11:58     ` Wander Lairson Costa
2024-09-23 16:45 ` Wander Lairson Costa
2024-09-25 15:29   ` Phil Auld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZqH-1o9pc062F-hG@jlelli-thinkpadt14gen4.remote.csb \
    --to=juri.lelli@redhat.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    --cc=wander@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®