mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Willy Tarreau <w@1wt.eu>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Ammar Faizi <ammarfaizi2@gnuweeb.org>,
	Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] tools/nolibc: include arch.h from string.h
Date: Thu, 25 Jul 2024 19:11:49 +0200	[thread overview]
Message-ID: <ZqKHVeZg+Tu6VV5f@1wt.eu> (raw)
In-Reply-To: <20240725-arch-has-func-v1-1-5521ed354acd@weissschuh.net>

Hi Thomas,

On Thu, Jul 25, 2024 at 06:54:18PM +0200, Thomas Weißschuh wrote:
> string.h tests for the macros NOLIBC_ARCH_HAS_$FUNC to use the
> architecture-optimized function variants.
> However if string.h is included before arch.h header than that check
                                                       ^^^^
then

> does not work, leading to duplicate function definitions.
> 
> Fixes: 553845eebd60 ("tools/nolibc: x86-64: Use `rep movsb` for `memcpy()` and `memmove()`")
> Fixes: 12108aa8c1a1 ("tools/nolibc: x86-64: Use `rep stosb` for `memset()`")
> Cc: stable@vger.kernel.org
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>

Good catch!

Acked-by: Willy Tarreau <w@1wt.eu>

Thanks,
Willy

      reply	other threads:[~2024-07-25 17:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-25 16:54 Thomas Weißschuh
2024-07-25 17:11 ` Willy Tarreau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZqKHVeZg+Tu6VV5f@1wt.eu \
    --to=w@1wt.eu \
    --cc=alviro.iskandar@gnuweeb.org \
    --cc=ammarfaizi2@gnuweeb.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@weissschuh.net \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®