mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Javier Carrasco <javier.carrasco@wolfvision.net>,
	Abdel Alkuor <abdelalkuor@geotab.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	dan.carpenter@linaro.org, kernel-janitors@vger.kernel.org,
	error27@gmail.com
Subject: Re: [PATCH 2/2] usb: typec: tipd: Delete extra semi-colon
Date: Tue, 30 Jul 2024 11:45:15 +0300	[thread overview]
Message-ID: <ZqioG3N9lcTxB6+7@kuha.fi.intel.com> (raw)
In-Reply-To: <20240724162356.992763-2-harshit.m.mogalapalli@oracle.com>

On Wed, Jul 24, 2024 at 09:23:51AM -0700, Harshit Mogalapalli wrote:
> There shouldn't be a ; at the end of the function, delete it.
> 
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
>  drivers/usb/typec/tipd/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
> index eb5596e3406a..dd51a25480bf 100644
> --- a/drivers/usb/typec/tipd/core.c
> +++ b/drivers/usb/typec/tipd/core.c
> @@ -1198,7 +1198,7 @@ static int tps6598x_apply_patch(struct tps6598x *tps)
>  	release_firmware(fw);
>  
>  	return ret;
> -};
> +}
>  
>  static int cd321x_init(struct tps6598x *tps)
>  {
> -- 
> 2.45.2

-- 
heikki

  parent reply	other threads:[~2024-07-30  8:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-24 16:23 [PATCH 1/2] usb: typec: tipd: Fix dereferencing freeing memory in tps6598x_apply_patch() Harshit Mogalapalli
2024-07-24 16:23 ` [PATCH 2/2] usb: typec: tipd: Delete extra semi-colon Harshit Mogalapalli
2024-07-25  5:45   ` Javier Carrasco
2024-07-30  8:45   ` Heikki Krogerus [this message]
2024-07-25  5:40 ` [PATCH 1/2] usb: typec: tipd: Fix dereferencing freeing memory in tps6598x_apply_patch() Javier Carrasco
2024-07-30  8:44 ` Heikki Krogerus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZqioG3N9lcTxB6+7@kuha.fi.intel.com \
    --to=heikki.krogerus@linux.intel.com \
    --cc=abdelalkuor@geotab.com \
    --cc=dan.carpenter@linaro.org \
    --cc=error27@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=harshit.m.mogalapalli@oracle.com \
    --cc=javier.carrasco@wolfvision.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®