From: Matthew Brost <matthew.brost@intel.com>
To: Tejun Heo <tj@kernel.org>
Cc: <intel-xe@lists.freedesktop.org>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
<jiangshanlai@gmail.com>, <christian.koenig@amd.com>,
<ltuikov89@gmail.com>, <daniel@ffwll.ch>
Subject: Re: [PATCH v2 3/5] workqueue: Add interface for user-defined workqueue lockdep map
Date: Wed, 31 Jul 2024 01:15:30 +0000 [thread overview]
Message-ID: <ZqmQMl2yurl1mqL1@DUT025-TGLU.fm.intel.com> (raw)
In-Reply-To: <ZqmG_c2tjKNAJWfh@slm.duckdns.org>
On Tue, Jul 30, 2024 at 02:36:13PM -1000, Tejun Heo wrote:
> Hello,
>
> On Tue, Jul 30, 2024 at 05:31:17PM -0700, Matthew Brost wrote:
> > +#define alloc_ordered_workqueue_lockdep_map(fmt, flags, lockdep_map, args...) \
> > + alloc_workqueue_lockdep_map(fmt, WQ_UNBOUND | __WQ_ORDERED | (flags), 1, lockdep_map, ##args)
> > +#endif
>
> alloc_ordered_workqueue() is a macro too but would you mind making this an
> inline function?
>
Not at all.
> > @@ -4795,11 +4795,17 @@ static void wq_init_lockdep(struct workqueue_struct *wq)
> >
> > static void wq_unregister_lockdep(struct workqueue_struct *wq)
> > {
> > + if (wq->flags & __WQ_USER_OWNED_LOCKDEP)
> > + return;
>
> Do you still need the flag? Can't you test wq->lockdep_map !=
> &wq->__lockdep_map instead?
>
Ah, yes. That is better. Will change.
Matt
> Thanks.
>
> --
> tejun
next prev parent reply other threads:[~2024-07-31 1:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 0:31 [PATCH v2 0/5] Use user-defined workqueue lockdep map for drm sched Matthew Brost
2024-07-31 0:31 ` [PATCH v2 1/5] workqueue: Split alloc_workqueue into internal function and lockdep init Matthew Brost
2024-07-31 0:31 ` [PATCH v2 2/5] workqueue: Change workqueue lockdep map to pointer Matthew Brost
2024-07-31 0:31 ` [PATCH v2 3/5] workqueue: Add interface for user-defined workqueue lockdep map Matthew Brost
2024-07-31 0:36 ` Tejun Heo
2024-07-31 1:15 ` Matthew Brost [this message]
2024-07-31 0:31 ` [PATCH v2 4/5] drm/sched: Use drm sched lockdep map for submit_wq Matthew Brost
2024-07-31 0:31 ` [PATCH v2 5/5] drm/xe: Drop GuC submit_wq pool Matthew Brost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZqmQMl2yurl1mqL1@DUT025-TGLU.fm.intel.com \
--to=matthew.brost@intel.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ltuikov89@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®