From: Raju Lakkaraju <Raju.Lakkaraju@microchip.com>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Raju Lakkaraju <Raju.Lakkaraju@microchip.com>,
<netdev@vger.kernel.org>, <davem@davemloft.net>,
<kuba@kernel.org>, <andrew@lunn.ch>, <horms@kernel.org>,
<hkallweit1@gmail.com>, <richardcochran@gmail.com>,
<rdunlap@infradead.org>, <Bryan.Whitehead@microchip.com>,
<edumazet@google.com>, <pabeni@redhat.com>,
<linux-kernel@vger.kernel.org>, <UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH net-next V3 3/4] net: lan743x: Migrate phylib to phylink
Date: Thu, 1 Aug 2024 16:33:13 +0530 [thread overview]
Message-ID: <ZqtrcRfRVBR6H9Ri@HYD-DK-UNGSW21.microchip.com> (raw)
In-Reply-To: <Zqj/Mdoy5rhD2YXx@shell.armlinux.org.uk>
Hi Russell King,
Thank you for review the patches.
The 07/30/2024 15:56, Russell King (Oracle) wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On Tue, Jul 30, 2024 at 07:36:18PM +0530, Raju Lakkaraju wrote:
> > + default:
> > + __set_bit(PHY_INTERFACE_MODE_RGMII,
> > + adapter->phylink_config.supported_interfaces);
> > + __set_bit(PHY_INTERFACE_MODE_RGMII_ID,
> > + adapter->phylink_config.supported_interfaces);
> > + __set_bit(PHY_INTERFACE_MODE_RGMII_RXID,
> > + adapter->phylink_config.supported_interfaces);
> > + __set_bit(PHY_INTERFACE_MODE_RGMII_TXID,
> > + adapter->phylink_config.supported_interfaces);
>
> There's a shorter way to write this:
>
> phy_interface_set_rgmii(adapter->phylink_config.supported_interfaces);
Ok. I will change.
>
> > +static int lan743x_phylink_connect(struct lan743x_adapter *adapter)
> > +{
> > + struct device_node *dn = adapter->pdev->dev.of_node;
> > + struct net_device *dev = adapter->netdev;
> > + struct fixed_phy_status fphy_status = {
> > + .link = 1,
> > + .speed = SPEED_1000,
> > + .duplex = DUPLEX_FULL,
> > + };
> > + struct phy_device *phydev;
> > + int ret;
> > +
> > + if (dn)
> > + ret = phylink_of_phy_connect(adapter->phylink, dn, 0);
> > +
> > + if (!dn || (ret && !lan743x_phy_handle_exists(dn))) {
> > + phydev = phy_find_first(adapter->mdiobus);
> > + if (!phydev) {
> > + if (((adapter->csr.id_rev & ID_REV_ID_MASK_) ==
> > + ID_REV_ID_LAN7431_) || adapter->is_pci11x1x) {
> > + phydev = fixed_phy_register(PHY_POLL,
> > + &fphy_status,
> > + NULL);
>
> I thought something was going to happen with this?
Our SQA confirmed that it's working ping as expected (i.e Speed at 1Gbps
with full duplex) with Intel I210 NIC as link partner.
Do you suspect any corner case where it's fail?
>
> --
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
--
Thanks,
Raju
next prev parent reply other threads:[~2024-08-01 11:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 14:06 [PATCH net-next V3 0/4] Add support to PHYLINK for LAN743x/PCI11x1x chips Raju Lakkaraju
2024-07-30 14:06 ` [PATCH net-next V3 1/4] net: lan743x: Create separate PCS power reset function Raju Lakkaraju
2024-07-30 14:06 ` [PATCH net-next V3 2/4] net: lan743x: Create separate Link Speed Duplex state function Raju Lakkaraju
2024-07-30 14:06 ` [PATCH net-next V3 3/4] net: lan743x: Migrate phylib to phylink Raju Lakkaraju
2024-07-30 14:56 ` Russell King (Oracle)
2024-08-01 11:03 ` Raju Lakkaraju [this message]
2024-08-01 16:27 ` Russell King (Oracle)
2024-08-01 23:46 ` Ronnie.Kunin
2024-08-02 8:37 ` Russell King (Oracle)
2024-08-08 20:23 ` Ronnie.Kunin
2024-08-08 21:07 ` Russell King (Oracle)
2024-08-16 17:38 ` Raju Lakkaraju
2024-08-17 11:42 ` Russell King (Oracle)
2024-07-30 14:06 ` [PATCH net-next V3 4/4] net: lan743x: Add support to ethtool phylink get and set settings Raju Lakkaraju
2024-07-30 15:11 ` Russell King (Oracle)
2024-08-01 11:05 ` Raju Lakkaraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZqtrcRfRVBR6H9Ri@HYD-DK-UNGSW21.microchip.com \
--to=raju.lakkaraju@microchip.com \
--cc=Bryan.Whitehead@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rdunlap@infradead.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®