From: Frank Li <Frank.li@nxp.com>
To: Bjorn Helgaas <helgaas@kernel.org>, Olof Johansson <olof@lixom.net>
Cc: "Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
Zhiqiang.Hou@nxp.com, linux-pci@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev
Subject: Re: [PATCH 4/4] MAINTAINERS: drop NXP LAYERSCAPE GEN4 CONTROLLER
Date: Fri, 16 Aug 2024 15:17:06 -0400 [thread overview]
Message-ID: <Zr+lslEn4cfBJ0A3@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20240816181500.GA69082@bhelgaas>
On Fri, Aug 16, 2024 at 01:15:00PM -0500, Bjorn Helgaas wrote:
> On Fri, Aug 16, 2024 at 01:09:50PM -0400, Frank Li wrote:
> > On Fri, Aug 16, 2024 at 11:12:31AM +0530, Manivannan Sadhasivam wrote:
> > > On Thu, Aug 15, 2024 at 03:15:52PM -0600, Rob Herring wrote:
> > > > On Thu, Aug 15, 2024 at 9:53 AM Manivannan Sadhasivam
> > > > <manivannan.sadhasivam@linaro.org> wrote:
> > > > > On Thu, Aug 08, 2024 at 12:02:17PM -0400, Frank Li wrote:
> > > > > > LX2160 Rev1 use mobivel PCIe controller, but Rev2 switch to designware
> > > > > > PCIe controller. Rev2 is mass production chip. Rev1 will not be maintained
> > > > > > so drop maintainer information for that.
> > > > >
> > > > > Instead of suddenly removing the code and breaking users, you can just mark the
> > > > > driver as 'Obsolete' in MAINTAINERS. Then after some point of time, we could
> > > > > hopefully remove.
> > > >
> > > > Is anyone really going to pay attention to that? It doesn't sound like
> > > > there's anyone to really care, and it is the company that made the h/w
> > > > asking to remove it. The only thing people use pre-production h/w for
> > > > once there's production h/w is as a dust collector.
> > > >
> > > > If anyone complains, it's simple enough to revert these patches.
> > >
> > > My comment was based on the fact that Bjorn was not comfortable in removing the
> > > driver [1] unless no Rev1 boards are not in use and Frank said that he was not
> > > sure about that [2].
> > >
> > > But I think if Frank can atleast guarantee that the chip never made into mass
> > > production or shared with customers, then we can remove the driver IMO. But that
> > > is up to the discretion of Bjorn.
> >
> > I think Bjorn's request is impossible task. Generally chip company send
> > out some evaluted sample to parter, which use these sample to built up
> > some small quantity production. Chip company have not responsibility to
> > call back this samples. There are always some reasons to drop mobivel and
> > switch designware, it may be caused by some IP issues which can't match
> > mass production's requirememnt. Such informaiton already removed from
> > nxp.com. Only Rev2 left.
>
> If you're reasonably confident that nobody will notice the removal of
> support for Rev1, we can include that in the commit log and just
> remove it.
>
> The original commit log basically said "we don't want to support Rev1"
> without any indication of where those parts went or whether anybody
> might care about them. But if Rev1 only went to partners for
> evaluation and we don't expect end users to have them, I think it's
> reasonable to say that and remove the code.
Thanks, I just find 2020 Yang li try to drop dts part in below thread:
https://lore.kernel.org/all/CAOesGMhz8PYNG_bgMX-6gka77k1hJOZUv6xqJRqATaJ6mFbk6A@mail.gmail.com/
Olof Johansson raise concern about their HoneyComb.
I added Olof Johansson in this thread. I think HoneyComb use evaluation
chip to build some small quaitity boards.
As my best knowledge, rev1 should have some big problem. I can't find any
detail about these because rev1 informaion already cleanup totally. I don't
prefer continue use risking rev1 chip.
Frank
>
> Bjorn
next prev parent reply other threads:[~2024-08-16 19:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 16:02 [PATCH 0/4] PCI: mobivel: Drop layerscape gen4 support Frank Li
2024-08-08 16:02 ` [PATCH 1/4] dt-bindings: PCI: layerscape-pci: drop compatible string fsl,lx2160a-pcie Frank Li
2024-08-10 14:58 ` Krzysztof Kozlowski
2024-08-08 16:02 ` [PATCH 2/4] dt-bindings: PCI: drop layerscape-pcie-gen4.txt Frank Li
2024-08-10 15:00 ` Krzysztof Kozlowski
2024-08-08 16:02 ` [PATCH 3/4] PCI: mobiveil: Drop layerscape-gen4 support Frank Li
2024-08-08 17:26 ` Bjorn Helgaas
2024-08-08 18:08 ` Frank Li
2024-08-10 15:01 ` Krzysztof Kozlowski
2024-08-08 16:02 ` [PATCH 4/4] MAINTAINERS: drop NXP LAYERSCAPE GEN4 CONTROLLER Frank Li
2024-08-10 14:54 ` Krzysztof Kozlowski
2024-08-15 15:53 ` Manivannan Sadhasivam
2024-08-15 21:15 ` Rob Herring
2024-08-16 5:42 ` Manivannan Sadhasivam
2024-08-16 17:09 ` Frank Li
2024-08-16 18:15 ` Bjorn Helgaas
2024-08-16 19:17 ` Frank Li [this message]
2024-08-16 23:14 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zr+lslEn4cfBJ0A3@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=Zhiqiang.Hou@nxp.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=helgaas@kernel.org \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=olof@lixom.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®