mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mary Strodl <mstrodl@freedom.csh.rit.edu>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Mary Strodl <mstrodl@csh.rit.edu>,
	linux-kernel@vger.kernel.org, linus.walleij@linaro.org,
	brgl@bgdev.pl, linux-gpio@vger.kernel.org
Subject: Re: [PATCH] gpio: add support for FTDI's MPSSE as GPIO
Date: Fri, 16 Aug 2024 08:23:16 -0400	[thread overview]
Message-ID: <Zr9EtK6qnj5apiie@freedom.csh.rit.edu> (raw)
In-Reply-To: <5d26a74d-af5c-490a-8a00-ca0791bb23f6@kernel.org>

Hello!

On Fri, Aug 16, 2024 at 07:52:43AM +0200, Krzysztof Kozlowski wrote:
> You should not need MODULE_ALIAS() in normal cases. If you need it,
> usually it means your device ID table is wrong (e.g. misses either
> entries or MODULE_DEVICE_TABLE()). MODULE_ALIAS() is not a substitute
> for incomplete ID table.

Gotcha. I will remove that next time this gets sent out. I'll probably
give it a few days so other folks can chime in, unless you'd like to
see this changed before reviewing in more depth?

I assumed it was there to make `gpio-mpsse` work in addition to
`gpio_mpsse`.

> The module with autoload based on USB ids, right?
Yep.

> Best regards,
> Krzysztof

Thanks for taking the time to review my patch!
Mary

  reply	other threads:[~2024-08-16 12:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-14 19:15 Mary Strodl
2024-08-16  5:52 ` Krzysztof Kozlowski
2024-08-16 12:23   ` Mary Strodl [this message]
2024-08-24 14:25 ` Linus Walleij
2024-08-29 14:11   ` Mary Strodl
2024-09-05 15:18     ` Mary Strodl
2024-10-11 11:59       ` Linus Walleij
2024-10-11 14:09         ` Mary Strodl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zr9EtK6qnj5apiie@freedom.csh.rit.edu \
    --to=mstrodl@freedom.csh.rit.edu \
    --cc=brgl@bgdev.pl \
    --cc=krzk@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mstrodl@csh.rit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®