From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DA961BCA0B for ; Fri, 16 Aug 2024 14:51:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723819882; cv=none; b=neBatuSpDhDVhBf2xpvNOHSI7j2CcfF8eZ9g8SgwRhN30GMcColVAUi46uHtQPKG15R6lXjJJvXuZoyaEliYsCXQQZZ2KwtV86SxqCi1mhngHWOdauZRQ689ZVuffdnWeepvwjZJ/dp9aLHSSOsJ5TOXEzkNifiKRgLif51m8Jw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723819882; c=relaxed/simple; bh=pRyHlCh8aSYYzHXx34WfX5hxoAw8zCK3wnS3r5G3XYI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HkYTPH+UBLWsLTnBcZFalz7FQKpZz7U/tpUkchHdCdvtDPqStD50P3oIc5TmiYPYGkngq6pYHbWc5B+BoCuzt/VfjgnvjbAarAw+FrFyEXgiEVRXbNqGVOlhs8ZVKzk1Zz6Y+vzoudHp4HhspQc8ar4mlnftdENxU13wU6aGn+I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=h5nYQv0y; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="h5nYQv0y" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1723819882; x=1755355882; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=pRyHlCh8aSYYzHXx34WfX5hxoAw8zCK3wnS3r5G3XYI=; b=h5nYQv0ytmBeQ9jLYuUEnb85KqB7rjWw8PlIGsgpNS+AQZ1YkTH+nOSv wE10VvwwMeN13ZD1QIgXoqPgybUk2gyAWApByP4DGTKdybUzcs6yNZU7H v8X5CIkxPwvvC8c8iIOx+kHjzq+7w9HjxBtR1n1Q6q5wEgfE0+yCcwJ1F GYB/i63neTn3XCGco/tBksdXHPo4qNuaX7ZC00WiYt0vHsnrtmmqdyIfv ik7iIibrnpAt8PNtys/Uc619zW2UMB2Tn7l0bso0uD3GQ8Ft2joQp1R0a 3MljxhWI3FfTh3DVwdr6gZFTWpD8MSb491Hzbr7SNKUTDc+E7B765uMAN g==; X-CSE-ConnectionGUID: 6wVYhGLkTsSisXi5yosMsQ== X-CSE-MsgGUID: iW9UmCJuQQOlNxdEwfkQNA== X-IronPort-AV: E=McAfee;i="6700,10204,11166"; a="33503179" X-IronPort-AV: E=Sophos;i="6.10,152,1719903600"; d="scan'208";a="33503179" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Aug 2024 07:51:19 -0700 X-CSE-ConnectionGUID: 2WEn18WyQweCjl5zF3pxQw== X-CSE-MsgGUID: 2rLDsdYBTRmn7nLy7PzoaQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,152,1719903600"; d="scan'208";a="64529984" Received: from smile.fi.intel.com ([10.237.72.54]) by orviesa003.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Aug 2024 07:51:12 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1seyIF-0000000FwGC-40M2; Fri, 16 Aug 2024 17:51:07 +0300 Date: Fri, 16 Aug 2024 17:51:07 +0300 From: Andy Shevchenko To: "Ding, Shenghao" Cc: "broonie@kernel.org" , "lgirdwood@gmail.com" , "perex@perex.cz" , "pierre-louis.bossart@linux.intel.com" , "13916275206@139.com" <13916275206@139.com>, "zhourui@huaqin.com" , "alsa-devel@alsa-project.org" , "Salazar, Ivan" , "linux-kernel@vger.kernel.org" , "Chadha, Jasjot Singh" , "liam.r.girdwood@intel.com" , "Yue, Jaden" , "yung-chuan.liao@linux.intel.com" , "Rao, Dipa" , "yuhsuan@google.com" , "Lo, Henry" , "tiwai@suse.de" , "Xu, Baojun" , "Baojun.Xu@fpt.com" , "judyhsiao@google.com" , "Navada Kanyana, Mukund" , "cujomalainey@google.com" , "Kutty, Aanya" , "Mahmud, Nayeem" , "savyasanchi.shukla@netradyne.com" , "flaviopr@microsoft.com" , "Ji, Jesse" , "darren.ye@mediatek.com" , "antheas.dk@gmail.com" , "Jerry2.Huang@lcfuturecenter.com" Subject: Re: [EXTERNAL] Re: [PATCH v1] ASoc: tas2781: Rename dai_driver name to unify the name between TAS2563 and TAS2781 Message-ID: References: <20240803032717.175-1-shenghao-ding@ti.com> <9ec30bafdec441078828cb0d7be93342@ti.com> <2a4f9f583b5e4495b9fb50a446c2c949@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2a4f9f583b5e4495b9fb50a446c2c949@ti.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Fri, Aug 16, 2024 at 01:41:46PM +0000, Ding, Shenghao wrote: > > From: Andy Shevchenko > > Sent: Thursday, August 15, 2024 8:04 PM > > To: Ding, Shenghao > > On Thu, Aug 15, 2024 at 03:02:01AM +0000, Ding, Shenghao wrote: > > > > From: Andy Shevchenko > > > > Sent: Monday, August 12, 2024 11:52 PM On Sat, Aug 03, 2024 at > > > > 11:27:14AM +0800, Shenghao Ding wrote: ... > > > > > + strscpy(name, "Speaker Profile Id", > > > > SNDRV_CTL_ELEM_ID_NAME_MAXLEN); > > > > > > > > > + strscpy(prog_name, "Speaker Program Id", > > > > > + SNDRV_CTL_ELEM_ID_NAME_MAXLEN); > > > > > > > > > + strscpy(conf_name, "Speaker Config Id", > > > > > +SNDRV_CTL_ELEM_ID_NAME_MAXLEN); > > > > > > > > Why not 2-parameter strscpy()? > > > strscpy seemed not support 2 params. Do you mean strcpy? > > > > 1. It does. > > 2. No, I meant strscpy(). > I have tried 2-parameter strscpy(), and occurred compiling issue. > The first parameter of strscpy, *dst, must be array, but in this code > prog_name and conf_name are points to the memories applied by > devm_kcalloc. Okay, I'm not sure why devm_kasprintf() is not used for these cases. -- With Best Regards, Andy Shevchenko