From: Boqun Feng <boqun.feng@gmail.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Christophe Jaillet <christophe.jaillet@wanadoo.fr>,
kernel-janitors@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Waiman Long <longman@redhat.com>, Will Deacon <will@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] locking/lockdep: Simplify character output in seq_line()
Date: Mon, 5 Aug 2024 10:46:25 -0700 [thread overview]
Message-ID: <ZrEP8QlnhztnwvWy@tardis> (raw)
In-Reply-To: <e346d688-7b01-462f-867c-ba52b7790d19@web.de>
On Mon, Jul 15, 2024 at 10:51:44AM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 15 Jul 2024 10:42:17 +0200
>
> Single characters should be put into a sequence.
> Thus use the corresponding function “seq_putc” for one selected call.
>
> This issue was transformed by using the Coccinelle software.
>
> Suggested-by: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Queued this at:
https://git.kernel.org/pub/scm/linux/kernel/git/boqun/linux.git/ lockdep-for-tip
Thanks! And given Christophe's comment, the original one is not needed,
so drop it.
Regards,
Boqun
> ---
> kernel/locking/lockdep_proc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/locking/lockdep_proc.c b/kernel/locking/lockdep_proc.c
> index e2bfb1db589d..6db0f43fc4df 100644
> --- a/kernel/locking/lockdep_proc.c
> +++ b/kernel/locking/lockdep_proc.c
> @@ -424,7 +424,7 @@ static void seq_line(struct seq_file *m, char c, int offset, int length)
> for (i = 0; i < offset; i++)
> seq_puts(m, " ");
> for (i = 0; i < length; i++)
> - seq_printf(m, "%c", c);
> + seq_putc(m, c);
> seq_puts(m, "\n");
> }
>
> --
> 2.45.2
>
next prev parent reply other threads:[~2024-08-05 17:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-14 10:25 [PATCH] locking/lockdep: Use seq_putc() in five functions Markus Elfring
2024-07-14 21:31 ` Waiman Long
2024-07-15 5:18 ` Christophe JAILLET
2024-07-15 8:51 ` [PATCH] locking/lockdep: Simplify character output in seq_line() Markus Elfring
2024-08-05 17:46 ` Boqun Feng [this message]
2024-08-08 10:22 ` [tip: locking/core] " tip-bot2 for Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZrEP8QlnhztnwvWy@tardis \
--to=boqun.feng@gmail.com \
--cc=Markus.Elfring@web.de \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®